London | 26-ITP-May | Edina Kurdi | Sprint 1 | coursework-Data-Groups - #1280
Open
edinakurdi wants to merge 10 commits into
Open
London | 26-ITP-May | Edina Kurdi | Sprint 1 | coursework-Data-Groups#1280edinakurdi wants to merge 10 commits into
edinakurdi wants to merge 10 commits into
Conversation
edinakurdi
added
🏕 Priority Mandatory
LonMcGregor
added
the
Review in progress
LonMcGregor
reviewed
Jul 27, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good work, some comments for improvements, but all tests pass
| function dedupe() {} | ||
| function dedupe(array) { | ||
| //create a duplicate,to avoid changing the array | ||
| const copiedArray = Array.from(array); |
There was a problem hiding this comment.
Do you need a copy of the array here?
Author
There was a problem hiding this comment.
Oh. I do not. Deleted, and corresponding references updated.
| elements = elements.filter((element) => typeof element === "number"); | ||
|
|
||
| // find maximum | ||
| const max = Math.max(...elements); |
There was a problem hiding this comment.
Can you implement this without using built-in max?
Author
There was a problem hiding this comment.
I updated the implementation without a built in method
LonMcGregor
added
Reviewed
edinakurdi
added
Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Sprint 1 tasks:
medianfunctionmaxsumdedupeincludes