Skip to content

London | May-26 | Liridona Shehu | Sprint 3 | Module-Data-Groups - Alarmclock #1309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shehu-dona wants to merge 3 commits into
base: main
Choose a base branch
from
+32 −2
Open

London | May-26 | Liridona Shehu | Sprint 3 | Module-Data-Groups - Alarmclock #1309

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c225fb2
Implement setAlarm()
dona-shehu Jul 26, 2026
7b4f9e5
Added script and title
dona-shehu Jul 26, 2026
c792c1a
created formatTime() and handel 0 ore negative input
dona-shehu Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 30 additions & 1 deletion Sprint-3/alarmclock/alarmclock.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,33 @@
function setAlarm() {}
let remainingSeconds = 0;
let intervalId;

function formatTime(totalSeconds) {
const minutes = Math.floor(totalSeconds / 60).toString().padStart(2, "0");
const seconds = Math.floor(totalSeconds % 60).toString().padStart(2, "0");
return `${minutes}:${seconds}`;
}
function setAlarm() {
clearInterval(intervalId);

const initialSeconds = Number(document.getElementById("alarmSet").value);
const timeRemainingHeading = document.getElementById("timeRemaining");
if (!initialSeconds || initialSeconds <= 0) {
timeRemainingHeading.innerText = "Please enter a positive number of seconds";
return;
}
Comment on lines +14 to +17

@Luro91 Luro91 Aug 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code is not matching the standard for formatting. (Indendation inside the brackets). How can you ensure consistent formatting of all your code?

remainingSeconds = initialSeconds;

@Luro91 Luro91 Jul 30, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if I start the alarm with 0 seconds or a negative value?

@shehu-dona shehu-dona Jul 30, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked for 0, negative or empty input.


timeRemainingHeading.innerText = `Time Remaining: ${formatTime(remainingSeconds)}`;

intervalId = setInterval(() => {
remainingSeconds--;
timeRemainingHeading.innerText = `Time Remaining: ${formatTime(remainingSeconds)}`;
if (remainingSeconds === 0) {
clearInterval(intervalId);
playAlarm();
}
}, 1000);
}

// DO NOT EDIT BELOW HERE

Expand Down
3 changes: 2 additions & 1 deletion Sprint-3/alarmclock/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@
<meta charset="utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<link rel="stylesheet" href="style.css" />
<title>Title here</title>
<title>Alarm clock app</title>
<script defer src="scripts.js"></script>
</head>
<body>
<div class="centre">
Expand Down
Loading