London | 26-ITP-May | Jorvan White | Sprint 2 | Coursework by JorvanW · Pull Request #1418 · CodeYourFuture/Module-Data-Groups

JorvanW · 2026-08-10T21:55:18Z

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

Created Pull Request from Sprint 2 Coursework and updated for Pull Request

Poonam-raj · 2026-08-11T08:52:51Z

+console.log(`${recipe.title} 
+  serves ${recipe.serves}
+  ingredients: 
+  ${recipe.ingredients.join("\n")}`);


Nice logic here

Poonam-raj · 2026-08-11T09:04:18Z

+test("creates a country currency code lookup for multiple codes",() => {
+  expect(createLookup(countryCurrencyPairs)).toEqual([[US, 'USD'], [CA, 'CAD'], [EN, 'GBP']]);
+})


You could test one currency pair first, maybe something not included in this list, and then move into a bigger list. Having two tests with different inputs really helps prove that things aren't hardcoded in your solution.

Poonam-raj · 2026-08-11T09:07:47Z


-test.todo("creates a country currency code lookup for multiple codes");
+test("creates a country currency code lookup for multiple codes",() => {
+  expect(createLookup(countryCurrencyPairs)).toEqual([[US, 'USD'], [CA, 'CAD'], [EN, 'GBP']]);


Where is countryCurrencyPairs coming from? When I run this test it fails. Please take another look.

updated both the test file and js file. Removed unnecessary sections.

Poonam-raj · 2026-08-11T11:09:28Z

    queryParams[key] = value;
+
+
+    console.log(pair)


remove logs before committing

Poonam-raj · 2026-08-11T11:18:40Z

 // Then it should return an empty object
-test.todo("tally on an empty array returns an empty object");
+test("tally on an empty array returns an empty object",() => {
+  expect(tally([])).toEqual([]);


Correction needed here, test asks for "return an empty object"

Poonam-raj · 2026-08-11T11:19:52Z

+function tally(array) {                    //(array) is the input to the function
+
+     if (!Array.isArray(array)){              //checking if array is actually an array
+  throw new Error("Input must be an array");
+  }
+
+  if (array.length === 0){                //if array is empty return a empty array 
+    return []
+  }
+
+
+  const result = {}                       //creates result as an empty object which will store the counts
+
+
+  for (const item of array){             //'for' loops through every item in the array 
+  if (result[item]){                    // checks if the item is already in the result{}
+      result[item]++}                   // If it is then '++' tells it to add 1 to the value 
+
+    else {
+      result[item] = 1;                // else is saying that if it doesn't exist then we give it a value of 1 


I generally appreciate the comments adding clarity for future ref and readers, but it's not needed and maybe makes the committed code messy. This solution is fairly easy to interpret without it and we want clean commits as much as possible

Poonam-raj · 2026-08-11T11:21:24Z

+test("When invert is passed, keys and values  in the object should be swapped ",() => {
+  expect({x : 10, y : 20}).toEqual({x : 10, y : 20});
+});


Was this test suite abandoned when you saw the questions in the js file?

this test suite is unfinished and not accurate to the goals of the function - see my last comment in the invert.js file

fixed the function and added more test cases

Poonam-raj · 2026-08-11T11:24:11Z

+

 // c) What does Object.entries return? Why is it needed in this program?
+// It returns an array of property into the object


This comment is clear - please rephrase.
What specifically does the method populate the array with?
why is it useful here?

added more context

Poonam-raj · 2026-08-11T11:25:24Z

+// The current return value only shows {key: 2}. It doesn't show the first key and value only the second, 
+// and it doesn't specify the second key. Its just defined as 'key'. 


Missing a part here - yes it's only catching the final key,value pair, and yes it's specifically saying 'key', but anything else wrong about the output?

added more context

Poonam-raj · 2026-08-11T11:26:40Z

+// The current return value only shows {key: 2}. It doesn't show the first key and value only the second, 
+// and it doesn't specify the second key. Its just defined as 'key'. 

 // e) Fix the implementation of invert (and write tests to prove it's fixed!)


This part is missing - your current test suite doesn't correctly test the behaviour of invert - check the example given in the top comment above again. You also haven't built the test suite up - start with a small example and build up to a bigger object. Please amend

Poonam-raj

Some great work writing tests and implementing solutions - a few comments worth addressing, especially in the interpret section where testing is particularly lacking

… properly

…object as required

…test cases for invert

JorvanW added 14 commits July 20, 2026 19:32

Updated code for median.js to pass the late expectations

2c983b7

Added code to dedupe.js

6c109e9

added code for max.js

d57add3

Added code to sum.js

e3befbb

modified code on includes.js to use a for...of loop

872ddf0

Changed code in address. js to specify houseNumber

6c28930

Updated code and added notes for author.js

bbf0a73

update the code and added notes to recipe.js

5c2b4b5

Added code and tests for contains.js

663412b

added code to lookup.test

4c0d767

added code and passed tests for querystring.test.js

827b052

added code and tests for tally.test and js

2c0a94c

updated tests output for tally.test

f583fd7

added answers to invert.js and added a .test.js page to

93df342

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

Merge branch 'main' into coursework/sprint-2

6998347

JorvanW added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 10, 2026

This comment has been minimized.

Sign in to view

github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 10, 2026

removed code from sprint 1 and removed prep folder

5b96abc

JorvanW added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 10, 2026

This comment has been minimized.

Sign in to view

github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 10, 2026

removed file

f6cf1e1

JorvanW added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 10, 2026

Poonam-raj added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 11, 2026

Poonam-raj reviewed Aug 11, 2026

View reviewed changes

Poonam-raj added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Aug 11, 2026

JorvanW mentioned this pull request Aug 12, 2026

26-ITP-May |Data Groups | Jorvan White JorvanW/My-Coursework-Planner#33

Open

JorvanW added 6 commits August 13, 2026 09:44

removed errors in the lookup.js code and updated the test to function…

fca3dde

… properly

removed console.log in code

edb970d

updated tally.js and tally.test to turn and empty array into a empty …

d7af84e

…object as required

removed excess comments in invert.js. fixed the code and added more …

37deb3c

…test cases for invert

updated answers for invert.js

bdcc0fc

removed unecessary comment

04d19dd

JorvanW added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Aug 13, 2026



		// c) What does Object.entries return? Why is it needed in this program?
		// It returns an array of property into the object

		// The current return value only shows {key: 2}. It doesn't show the first key and value only the second,
		// and it doesn't specify the second key. Its just defined as 'key'.

Uh oh!

Uh oh!

Conversation

JorvanW commented Aug 10, 2026

Changelist

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Choose a reason for hiding this comment

Uh oh!

Poonam-raj Aug 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Poonam-raj left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Poonam-raj Aug 11, 2026 •

edited

Loading