London | 26-ITP-May | Edina Kurdi | Sprint 2 | Coursework by edinakurdi · Pull Request #1422 · CodeYourFuture/Module-Data-Groups

edinakurdi · 2026-08-11T20:46:04Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

Data Groups - Sprint 2

Poonam-raj · 2026-08-12T09:53:05Z

+console.log(Object.values(author));
+// for (const value of author) {
+//   console.log(value);
+// }


A good workaround to print the values of the object.

Question - how could the for loop on lines 21 - 23 be changed (to a different loop for example) to achieve the same effect?

Created an alternative using a loop

Poonam-raj · 2026-08-12T09:55:26Z

+const recipeValues = Object.values(recipe);
+//  ["bruschetta", 2, ["olive oil", "tomatoes", "salt", "pepper"]]
+
+const ingredients = recipeValues.slice(-1)[0];
+// ["olive oil","tomatoes","salt","pepper"]
+


good use of methods but how could we reduce the amount of code we're writing here?

Is there a more direct way to access the ingredients so you can join them on line 25?

oh, i seem to have created more work for myself than needed. corrected now

Poonam-raj · 2026-08-12T10:02:35Z

+  if (keysInObject.includes(propertyName)) {
+    return true;
+  } else {
+    return false;
+  }
+}


How could you refactor these lines to be more concise?

yes, since it returns a boolean, I dont have to write if else statement. done.

Poonam-raj · 2026-08-12T10:04:47Z

+describe("when given valid inputs", () => {
+  test("should return an object where (Input ==> Output): keys:values ==> country code: corresponding currency", () => {
+    expect(
+      createLookup([
+        ["US", "USD"],
+        ["CA", "CAD"],
+      ])
+    ).toEqual({
+      US: "USD",
+      CA: "CAD",
+    });
+  });
+});


Could you have included a simpler test to start with for valid inputs?

i added a simpler input with only one array in the array (one country's data)

Poonam-raj · 2026-08-12T10:06:47Z

-test.todo("contains on empty object returns false");
+describe("given an empty object", () => {
+  test("should return false when passed to contains", () => {
+    expect(contains({}, "a").toBe(false));


This line fails - please correct it

oh those brackets... fixed now.

Poonam-raj · 2026-08-12T10:07:12Z

+    throw new Error("Invalid input. All elements should be arrays");
+  }
+
+  return Object.fromEntries(countryCurrencyPairs);


Nice choice of method

thank you i came across it when learning about iterating through objects. very handy.

Poonam-raj · 2026-08-12T10:07:57Z

+//each key-value pair will form an array in a bigger array (array of arrays of key-value pairs)

 // d) Explain why the current return value is different from the target output
+/* issues:
+- .key notation naming the key "key"
+- we only assign the key to value, but not reversing it
+*/


Nice explanations here

Poonam-raj · 2026-08-12T10:08:46Z

+      expect(tally(["a"])).toEqual({ a: 1 });
+      expect(tally(["a", "a", "a"])).toEqual({ a: 3 });
+      expect(tally(["a", "a", "b", "c"])).toEqual({ a: 2, b: 1, c: 1 });


I actually think these are three different behaviours and so deserve their own test blocks to anyone reading them test suite can see the different behaviours clearly.

Poonam-raj · 2026-08-12T10:09:31Z

@@ -1,3 +1,18 @@
-function tally() {}
+function tally(array) {
+  if (typeof array === "string") {


What if the input is a number or a boolean? How can you change this condition so it will hold up against any wrong input type?

yes, i took the instructions too literally :)
corrected and test written for this version

Poonam-raj · 2026-08-12T10:09:53Z

+    throw new Error("Input should be an array");
+  }
+
+  let tallySet = {};


Would this code still work if you made the variable a constant? Explain your answer :)

yes, and updated it.
It would work still, as the variable ramains the same, we are not trying to update it, merely working with the items inside

Poonam-raj · 2026-08-12T10:11:15Z

+  const keyValuePairs = queryString.split("&");
+
+  //filter out empty strings from the keyValuePairs array of strings
+  let filteredKeyValuePairs = keyValuePairs.filter(


could this be a const?

yes, and i changed it now. (as above) I need to rememer to use const instead of let

Poonam-raj

Few comments, slight amendments/refactors or explanations needed - take a look, nice work here though, good use of methods and testing throughout

edinakurdi added 15 commits July 24, 2026 00:48

explain and fix the bug in address

6a0643a

debug logging the values of an object

6de1246

format recipe output to log ingredients on new lines

2488a71

implement contains function

0291dfa

write tests for contains function

bced4fe

implement createLookup()

5866558

create tests for createLookup()

3423b50

implement tally function

2a62f58

write tests for tally function

0b6fc65

implement queryString()

9c07c98

add one extra test

95e7d98

implement function and answer Qs in the comments

4de66ef

add export for testing

078648c

create test file and add first test

6d32545

add another test

1e8685b

This comment has been minimized.

Sign in to view

edinakurdi added 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Data-Groups The name of the module. labels Aug 11, 2026

Poonam-raj added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 12, 2026

Poonam-raj reviewed Aug 12, 2026

View reviewed changes

Poonam-raj added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Aug 12, 2026

edinakurdi added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Aug 13, 2026

edinakurdi mentioned this pull request Aug 13, 2026

ITP-May-2026 | Data groups | Edina_Kurdi edinakurdi/My-Coursework-Planner#150

Open

9 tasks

Uh oh!

Uh oh!

Conversation

edinakurdi commented Aug 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Learners, PR Template

Changelist

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Poonam-raj left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

edinakurdi commented Aug 11, 2026 •

edited

Loading