Add functional tests for the new Symfony module assertions - #62
Closed
TavoNiievez wants to merge 1 commit into
Closed
Add functional tests for the new Symfony module assertions#62TavoNiievez wants to merge 1 commit into
TavoNiievez wants to merge 1 commit into
Conversation
TavoNiievez
added a commit
to TavoNiievez/module-symfony
that referenced
this pull request
Sep 3, 2026
The assertions added here are exercised by the companion pull requests Codeception/symfony-module-tests#62 (7.4), #63 (8.1), #64 (6.4) and #65 (5.4). Their head branches are dominant-assertions-<symfony version> on TavoNiievez/symfony-module-tests, so the stable branches this job checks out do not contain the new tests yet. Point the app checkout at those branches so both sides of the change are tested together. This wiring is temporary and must be reverted once the companion pull requests are merged. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BAYrsHzCVkfP9XrbidMeYo
Cover the assertions added in codeception/module-symfony: assertSessionHasFlashMessage(), mockService(), seeNumQueriesIsLessThan()/dontSeeDuplicateQueries() and the Messenger in-memory transport assertions. Add the matching app fixtures: a flash-and-redirect controller (/flash), a Greeting service behind /greeting to swap with mockService(), a query-heavy /run-queries page for the Doctrine query-count assertions, and an in-memory async transport with SendWelcomeMessage routed to it. The console ExecutionResult assertions need symfony/console 8.1, so they are covered on the 8.1 branch only.
TavoNiievez
force-pushed
the
dominant-assertions-7.4
branch
from
September 3, 2026 18:12
3a398a1 to
a15c9b0
Compare
Member
Author
|
Closed and recreated from the same branch (same commit) to clear a stale cross-reference left in this timeline by a force-push. The replacement is pull request 68. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Functional coverage for the new assertions added in codeception/module-symfony (
assertSessionHasFlashMessage,mockService/unmockService,seeNumQueriesIsLessThan/dontSeeDuplicateQueries, and the Messenger in-memory transport assertions).Adds the matching app fixtures:
/flash) forassertSessionHasFlashMessage;Greetingservice +/greetingpage swapped viamockService;/run-queriespage for the Doctrine query-count assertions;asynctransport withSendWelcomeMessagerouted to it for the Messenger transport assertions.The console
ExecutionResultassertions are Symfony 8.1+ only, so they are covered on the8.1branch instead of here.