Demonstrate first-class PHP configuration (core PR #6946)#66
Draft
TavoNiievez wants to merge 1 commit into
Draft
Demonstrate first-class PHP configuration (core PR #6946)#66TavoNiievez wants to merge 1 commit into
TavoNiievez wants to merge 1 commit into
Conversation
Replace the YAML Codeception config with the new PHP config format and link codeception/codeception to the php_config branch (PR #6946) so the GlobalConfig / SuiteConfig builders are available. - Delete codeception.yml and tests/Functional.suite.yml - Add codeception.php and tests/Functional.suite.php (equivalent config) - composer: add a VCS repo for Codeception/Codeception and require "dev-php_config as 5.3.x-dev"; refresh composer.lock accordingly - CI: also trigger on the 8.1-php-config branch Illustrative / draft only: do not merge until PR #6946 lands, after which the composer link must revert to a stable codeception/codeception release. Verified: config:validate loads the .php config, and the Functional suite passes (138 tests, 258 assertions) against the php_config core.
706e21f to
2f58646
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Delete
codeception.ymlandtests/Functional.suite.yml.Add their PHP equivalents:
codeception.phptests/Functional.suite.phpcomposer.json— link the core to thephp_configbranch (that is where the builders live):The inline alias keeps
module-doctrine(^5.1) and themodule-asserts(< 5.0) constraintssatisfied.
composer.lockis refreshed and pins the branch commit so CI'scomposer installworks.CI (
.github/workflows/symfony.yml) — also triggers on8.1-php-config.