Repository navigation
fix(black-friday): treat active_expired licenses as expired - #4675
Open
Soare-Robert-Daniel wants to merge 1 commit into
Open
Soare-Robert-Daniel wants to merge 1 commit into
Soare-Robert-Daniel wants to merge 1 commit into
Conversation
The SDK reports expired-but-active licenses as `active_expired`, but the check only matched `active-expired`, so these users got the free offer. Accept both values. Refs Codeinwp/themeisle#2097 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Soare-Robert-Daniel
marked this pull request as ready for review
October 27, 2026 16:47
Collaborator
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Neve Pro users whose licence expired, but is still active on their site, get the free-user Black Friday offer. The status check compared against
active-expired, but the SDK and the store sendactive_expired; the check now accepts both.Note
The bug was added in
729c7d6fon versionv4.2.4(2026-05-21).active_expiredlicence now gets the expired offer: "Your Neve Pro features are still here, just locked. Renew at a reduced rate this week and pick up right where you left off." with a Reactivate now button. Before, it got the free-user offer, and the link had noexpired=1.Note
active-expiredstays in the check. Thetest-black-fridayhelper still writes that value.QA
You need a test site with the Neve theme and the Neve Pro plugin, and no other ThemeIsle product. The SDK shows one Black Friday notice per site, so another product can replace this one.
Add this file to force the 2026 sale window:
Create a key with the status Active Expired in the dummy licence generator. Activate it:
Expect: this command prints
active_expired:Go to
WP Admin → Dashboard.Expect: the Black Friday notice says "Your Neve Pro features are still here, just locked. Renew at a reduced rate this week and pick up right where you left off." The button says Reactivate now.
Hover the Reactivate now button.
Expect: the link starts with
https://themeisle.link/neve-bfand containsexpired=1.Go to
WP Admin → Plugins.Expect: the Pro plugin row shows the red link Black Friday Sale - 50% off.
Deactivate the key with
wp neve deactivate <key>, then go toWP Admin → Dashboard.Expect: the notice shows the free-user offer, with a title that ends in "60% off this week".
Refs Codeinwp/themeisle#2097
🤖 Generated with Claude Code