Skip to content

fix(zim): skip Zim update when Zim is not configured #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hlclarog wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(zim): skip Zim update when Zim is not configured #286

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions scripts/package/src/package_managers/zim.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
# shellcheck shell=bash
# Zim is optional: a zsh setup without it never sets ZIM_HOME.
zim::is_configured() {
[[ -n ${ZIM_HOME:-} && -f "$ZIM_HOME/zimfw.zsh" ]]
}

zim::update_all() {
zsh "$ZIM_HOME/zimfw.zsh" upgrade 2>&1 | log::file "Upgrading Zim" &&
zsh "$ZIM_HOME/zimfw.zsh" update 2>&1 | log::file "Updating Zim" &&
output::answer "Done"
}
3 changes: 2 additions & 1 deletion scripts/package/update_all
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ source "$DOTLY_PATH/scripts/package/src/package_managers/gem.sh"
source "$DOTLY_PATH/scripts/package/src/package_managers/mas.sh"
source "$DOTLY_PATH/scripts/package/src/package_managers/npm.sh"
source "$DOTLY_PATH/scripts/package/src/package_managers/pip.sh"
source "$DOTLY_PATH/scripts/package/src/package_managers/zim.sh"

##? Update all packages
##?
Expand All @@ -30,7 +31,7 @@ platform::command_exists cargo && output::h2 '馃摝 cargo' && cargo::update_all

platform::command_exists tldr && output::h2 '馃摐 tldr database' && tldr --update >/dev/null 2>&1 && output::answer "Database updated"

output::h2 "馃懡 Zim Framework" && zsh "$ZIM_HOME/zimfw.zsh" upgrade 2>&1 | log::file "Upgrading Zim" && zsh "$ZIM_HOME/zimfw.zsh" update 2>&1 | log::file "Updating Zim" && output::answer "Done"
zim::is_configured && output::h2 "馃懡 Zim Framework" && zim::update_all

output::h2 "馃寶 dotly" && dot self update >/dev/null 2>&1 && output::answer "Done"

Expand Down