feat(dashboard): unify range-input styling and add slider/physics regression coverage - #193
Merged
Merged
Conversation
…ression coverage - ledger.css: exempt range inputs from the global text-field styling block (input:not([type=range])) and give bare range inputs their own minimal rule (no padding/border, transparent background) so the 17 slider controls render as sliders instead of boxed text fields. - test_ledger_sliders_and_physics.py (new): exercises the real shipped assets via the Node engine harness + HTML/CSS parsers — slider bounds, monotone 1:1 mappings, zero dead zones, synchronized outputs, galaxy gravity physics (hierarchical orbits, carrier response, zero-G stability, orbit pause), non-galaxy presets, Every-node, 4 themes, color contrast variables, and all buttons/switches. - ledger_sliders_themes.spec.js (new e2e): full dashboard pass — CSP, console-error, and interaction checks across all sliders/themes. Verified: unit 7/7, e2e 1/1 (chromium, ENGRAPHIS_PLAYWRIGHT_PORT=8712), externalize_dashboard_assets gate clean.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dashboard slider polish + regression coverage
Validates and locks in the v1.1 Ledger dashboard slider/theme surface. 3 files:
ledger.css(+7/−1), newtests/test_ledger_sliders_and_physics.py(520 lines), newtests/e2e/ledger_sliders_themes.spec.js(e2e, 18s chromium).CSS
input:not([type="range"]), select, textarea— exempt range inputs from the global text-field styling block, with a dedicated minimalinput[type="range"]rule (no padding/border, transparent background). Sliders render as sliders, not boxed text fields.New unit coverage (7 tests, Node engine harness + HTML/CSS parsers against the real shipped assets)
New e2e coverage (chromium)
Full dashboard pass: CSP + console-error checks across all sliders, themes, and options.
Verification
externalize_dashboard_assetsgate clean; no published evidence numbers touched