_retryCount is shared between multiple requests making it dangerous to infinite requests #170

Activity

1. itsUndefined

   assigned

   CodingAleCR

   on Sep 26, 2025
2. itsUndefined

   added

   bugSomething isn't workingSomething isn't working

   on Sep 26, 2025
3. itsUndefined commented on Sep 26, 2025

   

   itsUndefined

   on Sep 26, 2025

   Author

   More actions

   I fixed the issue locally by changing the method _attemptRequest to the following:

   Future<BaseResponse> _attemptRequest(BaseRequest request,
         {bool isStream = false, int retryCount = 0}) async {
       BaseResponse response;
       try {
         // Intercept request
         final interceptedRequest = await _interceptRequest(request);
   
         var stream = requestTimeout == null
             ? await _inner.send(interceptedRequest)
             : await _inner
                 .send(interceptedRequest)
                 .timeout(requestTimeout!, onTimeout: onRequestTimeout);
   
         response = isStream ? stream : await Response.fromStream(stream);
   
         if (retryPolicy != null &&
             retryPolicy!.maxRetryAttempts > retryCount &&
             await retryPolicy!.shouldAttemptRetryOnResponse(response)) {
           await Future.delayed(retryPolicy!
               .delayRetryAttemptOnResponse(retryAttempt: retryCount + 1));
           return _attemptRequest(request, retryCount: retryCount + 1);
         }
       } on Exception catch (error) {
         if (retryPolicy != null &&
             retryPolicy!.maxRetryAttempts > retryCount &&
             await retryPolicy!.shouldAttemptRetryOnException(error, request)) {
           await Future.delayed(retryPolicy!
               .delayRetryAttemptOnException(retryAttempt: retryCount + 1));
           return _attemptRequest(request, retryCount: retryCount + 1);
         } else {
           rethrow;
         }
       }
   
       return response;
     }

   I also removed the global _retryCount variable.

   I tried to open a PR to fix this on the master branch but I noticed the project is taken over by AI Slop and the code was very different between what's published on pub ( 2.0.0 ) and master.
4. CodingAleCR commented on Mar 18, 2026

   

   CodingAleCR

   on Mar 18, 2026

   Owner

   More actions

   Yeah, there was an attempt to fix things using AI when it wasn't properly handled. That and the fact that the API decisions made in the past by myself were not the best. It led the library towards something much more cumbersome to maintain. I ended up rewriting most of it, keeping few things and will likely end 2.x version and its (very much lacking) support.
5. CodingAleCR commented on Mar 18, 2026

   

   CodingAleCR

   on Mar 18, 2026

   Owner

   More actions

   Take a look at #173 if you are still interested, since I know it's been quite a while since you took interest in this 🙏🏼

   ❤️React with ❤️1Reacted by Themistoklis Chatziemmanouil