Fix stale Mk4 firmware size constants - #68
Open
scgbckbone wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the public client constants to match the firmware and bootloader limits. The old 0x1e0000 value extends past the world-checksum-covered firmware region; the correct maximum is 0x160000. Also exposes the separate DFU container-size limit used by the firmware.\n\nThere is no live enforcement gap because devices already reject oversized firmware, but keeping the stale public constant risks downstream and future callers inheriting the invalid bound.\n\nTests not run (constant-only sync).