Repository navigation
Conversation
|
@jay23606 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement ( “Agreement” ) is agreed to by the party signing below ( “You” ), 1. Definitions. “Code” means the computer software code, whether in human-readable or machine-executable form, “Project” means any of the projects owned or managed by .NET Foundation and offered under a license “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any “Submission” means the Code and any other copyrightable material Submitted by You, including any 2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any 3. Originality of Work. You represent that each of Your Submissions is entirely Your 4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else 5. Licenses. a. Copyright License. You grant .NET Foundation, and those who receive the Submission directly b. Patent License. You grant .NET Foundation, and those who receive the Submission directly or c. Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement. 6. Representations and Warranties. You represent that You are legally entitled to grant the above 7. Notice to .NET Foundation. You agree to notify .NET Foundation in writing of any facts or 8. Information about Submissions. You agree that contributions to Projects and information about 9. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and 10. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and .NET Foundation dedicates this Contribution License Agreement to the public domain according to the Creative Commons CC0 1. |
Problem
TableController<TEntity>.QueryAsyncreturnsPagedResult.NextLinkas a query string only (for example$skip=50&$top=50). Datasync v6 clients and earlier resolvenextLinkagainst the host root and sendX-ZUMO-OPTIONS: nextLink=pathto say so. With a query-onlynextLink, those clients request the wrong URL, so paging fails once a result set exceedsPageSize.Change
IsLegacyClient(HttpRequest), which returnstruewhen theX-ZUMO-OPTIONSheader containsnextLink=path(case-insensitive).QueryAsynccomputes this once and passes it toBuildPagedResult, which passes it toCreateNextLink.CreateNextLinkreturns the host-relative path with no leading slash, followed by the query string, for exampletables/<table>?$skip=50&$top=50. Other clients keep the query-only format.Testing
dotnet test tests/CommunityToolkit.Datasync.Server.Test --filter "FullyQualifiedName~Query_LegacyClient_NextLinkIsRelativePath"passes on the fix. On the base source, with the same test file, it fails withAssert.StartsWith() Failure.dotnet test tests/CommunityToolkit.Datasync.Server.Test --filter "FullyQualifiedName!~Live"passes: 561 of 561.dotnet test tests/CommunityToolkit.Datasync.Server.Testexits with code 2. The live PostgreSQL tests fail withDockerUnavailableExceptionbecause Docker is not running here. Those tests are not exercised by this change. CI needs to confirm the full suite.Regression test: fails on base twice (/Assert.StartsWith() Failure/), passes on fix twice (
dotnet test tests/CommunityToolkit.Datasync.Server.Test --filter "FullyQualifiedName~Query_LegacyClient_NextLinkIsRelativePath")Fixes #629