Skip to content

ci(templates): scope packages: write to the app-deploy image job - #950

Merged
rubenvdlinde merged 1 commit into
feat/app-deploy-templatesfrom
ci/app-deploy-image-job-scoped-package-write
Nov 20, 2026
Merged

rubenvdlinde merged 1 commit into
feat/app-deploy-templatesfrom
ci/app-deploy-image-job-scoped-package-write

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

The app-deploy image workflow granted packages: write to the whole workflow. This moves it to the image job, the only job that pushes to ghcr.io, and leaves contents: read at workflow level.

ConductionNL/openregister#10938 makes the same change in openregister's rendered .github/workflows/container-image.yml. Without this PR a re-render with render.sh would undo it.

The template lives on feat/app-deploy-templates (#928), which is not on main yet, so this PR targets that branch.

Verified locally:

  • render.sh openregister on a scratch repo renders container-image.yml byte-identical to the file at the head of openregister#10938.
  • The template parses as YAML.

🤖 Generated with Claude Code

The workflow-level permissions now grant contents: read only; the image job, which pushes to ghcr.io, gets packages: write. Same change as ConductionNL/openregister#10938, so a re-render keeps it.

Assisted-by: ClaudeCode:claude-opus-5-5
@rubenvdlinde
rubenvdlinde merged commit 6ec1262 into feat/app-deploy-templates Nov 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant