Repository navigation
ci(templates): scope packages: write to the app-deploy image job - #950
Merged
rubenvdlinde merged 1 commit intoNov 20, 2026
Conversation
The workflow-level permissions now grant contents: read only; the image job, which pushes to ghcr.io, gets packages: write. Same change as ConductionNL/openregister#10938, so a re-render keeps it. Assisted-by: ClaudeCode:claude-opus-5-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The app-deploy image workflow granted
packages: writeto the whole workflow. This moves it to theimagejob, the only job that pushes to ghcr.io, and leavescontents: readat workflow level.ConductionNL/openregister#10938 makes the same change in openregister's rendered
.github/workflows/container-image.yml. Without this PR a re-render withrender.shwould undo it.The template lives on
feat/app-deploy-templates(#928), which is not onmainyet, so this PR targets that branch.Verified locally:
render.sh openregisteron a scratch repo renderscontainer-image.ymlbyte-identical to the file at the head of openregister#10938.🤖 Generated with Claude Code