Repository navigation
feat(hydra-gates): ship the values ObjectServiceInterface names, and ObjectFileReaderInterface - #951
Merged
Conversation
…ObjectFileReaderInterface Copies openregister's lib/Contract byte for byte after its task 7.2: the thirteen value classes the published ObjectServiceInterface now names, the widened ObjectServiceInterface, and ObjectFileReaderInterface, which was in lib/Contract but missing here and kept gate 67 red. Assisted-by: ClaudeCode:claude-opus-5-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ships openregister's published contract after its task 7.2, so gate 67 matches again.
What it adds to
hydra-gates/contracts/, each a byte-for-byte copy of openregister'slib/Contract/on ConductionNL/openregister#10985:ObjectServiceInterfacenames in its signatures:ObjectSaveOptions,BulkSaveOptions,ObjectFindOptions,ObjectDeletion,ObjectPatch,LockRequest,UnlockRequest,ObjectValidationVerdict,ObjectFindTarget,SaveActor,SavePolicy,BulkBatchDefaultsandLockRunStep.ObjectServiceInterface.php, whose signatures now name those published values.ObjectFileReaderInterface.php. It is already in openregister'slib/Contract/on main but was never shipped here, which is why gate 67 is red on openregister main today.README: the table of shipped files, a note on how a leaf app's test double stays compatible with both the old and the new contract (type the parameter
OldName|PublishedName), the bootstrap guard list and the Psalm stub list.Checked locally:
check_openregister_contract_parity.pyagainst openregister#10985'slib/Contract:checked 19 file(s), exit 0.test_shipped_contracts_documented.py: 4 tests OK.test_gate67_contract_parity_scope.sh: all cases behaved.Landing order: this PR first, then ConductionNL/integriq#3765, then openregister #10976, #10977 and #10985. The six other fleet test-double PRs have already merged. As the README says, an openregister checkout whose
composer.lockpins an older hydra-gates release keeps reporting these files missing locally until a release is cut and the lock moves. CI reads the copy beside the runner.AI assistance: prepared with Claude Code; the change was drafted in a cloud session that could not push to this repository, and applied and checked locally.
🤖 Generated with Claude Code