Skip to content

test(extension): answer the http question in the e2e pickers - #1938

Merged
rubenvdlinde merged 1 commit into
developmentfrom
cloud/b-keepiq-ext-e2e-http-question
Nov 21, 2026
Merged

rubenvdlinde merged 1 commit into
developmentfrom
cloud/b-keepiq-ext-e2e-http-question

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

What

The browser-extension workflow's e2e job has failed on development since 14 Nov (18 tests in inline-list.spec.ts and totp.spec.ts). Commit 11f3b67 made the extension ask before any login fill on an http: page, as the health-site-checks spec requires. The e2e test site is served on http://localhost, so every login pick now opens the insecure-page question, and the pickers never answered it.

The product code stays as it is. The e2e pickers answer the question:

  • mousePickFills clicks Fill on the question with a real mouse click, behind the same 500 ms guard.
  • keyboardPickFills presses Tab from Cancel to Fill, then Enter.
  • totp.spec.ts code and login pickers do the same through answerInsecure().

Verification

  • Ran locally in headless Chromium: 138 passed, 3 failed. The 3 failures are the a login leads to the … code step cases. They also fail locally at the commit before 11f3b67, where CI passed them, so they come from the local browser build, not from this change. The CI run on this PR is the real check.
  • npm run lint and npm run typecheck in browser-extension/ are clean.

Relates to task 2.1 of clients-extension-firefox-and-safari-builds (the workflow run).


Generated by Claude Code

Since the extension asks before any login fill on an http page (spec
health-site-checks), the e2e pickers on the http test site no longer
filled, and 18 tests of the browser-extension workflow failed on
development. The mouse and keyboard pickers and the code picker now
answer Fill on the question, with a real click or key behind the same
guard.

Assisted-by: ClaudeCode:claude-opus-5-5
@rubenvdlinde
rubenvdlinde merged commit b75bf6e into development Nov 21, 2026
42 of 44 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/keepiq @ c2ec273

Check PHP Vue Security License Tests
lint ✅
phpcs ✅
phpmd ❌
psalm ✅
phpstan ✅
phpmetrics ✅
eslint ✅
stylelint ✅
build ✅
check-manifest ✅
check-path-case ✅
test-l10n ✅
format ❌
check-l10n-js ✅
check-schema-l10n ✅
composer ✅ ✅ 114/114
npm ✅ ✅ 653/653
app:check-code ⏭️
info.xml ✅
REUSE ✅
lockfile sync ✅
PHPUnit ❌
Newman ❌
Playwright ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development.
Hydra gates ✅

Quality workflow — 2026-11-21 17:05 UTC

Download the full PDF report from the workflow artifacts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant