Repository navigation
test(extension): answer the http question in the e2e pickers - #1938
Merged
Merged
Conversation
Since the extension asks before any login fill on an http page (spec health-site-checks), the e2e pickers on the http test site no longer filled, and 18 tests of the browser-extension workflow failed on development. The mouse and keyboard pickers and the code picker now answer Fill on the question, with a real click or key behind the same guard. Assisted-by: ClaudeCode:claude-opus-5-5
Contributor
Quality Report — ConductionNL/keepiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ❌ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| check-path-case | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ❌ | ||||
| check-l10n-js | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 114/114 | |||
| npm | ✅ | ✅ 653/653 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ✅ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ | ||||
| Newman | ❌ | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ✅ |
Quality workflow — 2026-11-21 17:05 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The browser-extension workflow's
e2ejob has failed on development since 14 Nov (18 tests ininline-list.spec.tsandtotp.spec.ts). Commit 11f3b67 made the extension ask before any login fill on anhttp:page, as thehealth-site-checksspec requires. The e2e test site is served onhttp://localhost, so every login pick now opens the insecure-page question, and the pickers never answered it.The product code stays as it is. The e2e pickers answer the question:
mousePickFillsclicks Fill on the question with a real mouse click, behind the same 500 ms guard.keyboardPickFillspresses Tab from Cancel to Fill, then Enter.totp.spec.tscode and login pickers do the same throughanswerInsecure().Verification
a login leads to the … code stepcases. They also fail locally at the commit before 11f3b67, where CI passed them, so they come from the local browser build, not from this change. The CI run on this PR is the real check.npm run lintandnpm run typecheckinbrowser-extension/are clean.Relates to task 2.1 of
clients-extension-firefox-and-safari-builds(the workflow run).Generated by Claude Code