Repository navigation
ci(extension): load the Firefox package in headless Firefox - #1939
Merged
Merged
Conversation
The check-and-build job now installs .output/firefox-mv2 as a temporary add-on over geckodriver, opens its popup page and requires the background to answer settings.get (clients-browser-builds § Firefox starts the background). Playwright cannot load an extension into Firefox, so the script speaks WebDriver classic, like the Safari smoke test. Assisted-by: ClaudeCode:claude-opus-5-5
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
November 21, 2026 15:44
The Safari and Firefox smoke tests now take step, status polling, commands and the session from scripts/webdriver.ts instead of each keeping a copy. Assisted-by: ClaudeCode:claude-opus-5-5
Node runs the smoke scripts with its own type stripping, which resolves no extensionless relative import. Assisted-by: ClaudeCode:claude-opus-5-5
… check WebDriver may not navigate to a moz-extension page, so the check now reads the background's state from the chrome context (system access), requires it running, opens the popup in a tab of its own as the system and asks the background from there. Assisted-by: ClaudeCode:claude-opus-5-5
Assisted-by: ClaudeCode:claude-opus-5-5
geckodriver refuses --remote-allow-system-access as a capability; it takes --allow-system-access on its own command line. Assisted-by: ClaudeCode:claude-opus-5-5
…rapper WebDriver's script sandbox sees an extension page through Xray wrappers, which hide the page's own browser object; the check now reads it through window.wrappedJSObject. Assisted-by: ClaudeCode:claude-opus-5-5
Contributor
Quality Report — ConductionNL/keepiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ❌ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| check-path-case | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ❌ | ||||
| check-l10n-js | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 114/114 | |||
| npm | ✅ | ✅ 653/653 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ✅ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ | ||||
| Newman | ❌ | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ✅ |
Quality workflow — 2026-11-21 19:16 UTC
Download the full PDF report from the workflow artifacts.
…inds no browser API cloud-merge-keepiq Assisted-by: ClaudeCode:claude-opus-5-5
cloud-merge-keepiq Assisted-by: ClaudeCode:claude-opus-5-5
…s, in a trusted tab The guessed moz-extension host left the Firefox check's tab on about:blank. cloud-merge-keepiq Assisted-by: ClaudeCode:claude-opus-5-5
…nsions in process WebDriver's content context stayed on about:blank after the popup tab moved into the extension process. cloud-merge-keepiq Assisted-by: ClaudeCode:claude-opus-5-5
…its own cloud-merge-keepiq Assisted-by: ClaudeCode:claude-opus-5-5
…eter cloud-merge-keepiq Assisted-by: ClaudeCode:claude-opus-5-5
cloud-merge-keepiq Assisted-by: ClaudeCode:claude-opus-5-5
cloud-merge-keepiq Assisted-by: ClaudeCode:claude-opus-5-5
Contributor
Quality Report — ConductionNL/keepiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ❌ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| check-path-case | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ❌ | ||||
| check-l10n-js | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 114/114 | |||
| npm | ✅ | ✅ 653/653 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ✅ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ | ||||
| Newman | ❌ | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ✅ |
Quality workflow — 2026-11-22 00:31 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Task 2.1 of
clients-extension-firefox-and-safari-buildsasks for a workflow job that loads Chromium and Firefox headless and checks that the background starts. Chromium is already covered: thee2ejob loads the extension in headless Chromium. Firefox had onlyweb-ext lint.This PR adds
browser-extension/scripts/firefox-smoke.tsand a step incheck-and-build. The step starts the runner image's geckodriver. The script installs.output/firefox-mv2as a temporary add-on, with itsmoz-extension://host fixed through theextensions.webextensions.uuidspref. It then openspopup.htmland requires the background to answer a read-onlysettings.get. This is the spec scenario "Firefox starts the background": the background script runs and the popup can reach it.It follows the same pattern as the Safari smoke test (WebDriver classic over
fetch, no new dependencies).Verification
scripts/firefox-smoke.test.ts: 17 vitest cases (capabilities, the page script's success and failure replies, retries while the background starts, the wrong add-on id, the install refused, a hung request, geckodriver down).npm test(8812 passed),npm run typecheckandnpm run lintare clean.Generated by Claude Code