Skip to content

feat(visibility): owners change and remove the rules of their own widgets - #1489

Merged
rubenvdlinde merged 1 commit into
developmentfrom
feat/owners-edit-their-rules
Nov 21, 2026
Merged

rubenvdlinde merged 1 commit into
developmentfrom
feat/owners-edit-their-rules

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

Builds Ruben's answer of 21 Nov 2026: owners may also update and delete visibility rules on their own dashboards, and admins keep the right for every dashboard.

What changes:

  • rule.update-rule and rule.delete-rule are open to every user in lib/actions.seed.json. The action baseline repair step (revision 7) opens them on existing instances where the entry is still the pristine admin-only default.
  • Each route still checks placement ownership before it reads or writes. PermissionService::verifyPlacementOwnership() now also lets a Nextcloud administrator through, so admins keep the right for every dashboard. Before this, the check let only the owner through, admins included.
  • REQ-VIS-003 and REQ-VIS-004 in openspec/specs/conditional-visibility/spec.md now say so, and the stale "update/delete do not verify ownership" note is removed.
  • Tests: the repair revision, the baseline, a Nextcloud admin passing the ownership check (a LaunchPad Admin who is not one still has to own the dashboard), and a new e2e where an ordinary owner changes and removes her rule under the shipped matrix.

Verified locally: diff check green apart from gate-23 (tenant theme classes, not touched). The PermissionService phpmd findings (TooManyMethods, CouplingBetweenObjects) are identical on development. composer check:strict once: PHPUnit 5504 tests green; phpcs warnings, phpmd unused parameters and psalm (needs PHP 8.3.16) are inherited.

Written with Claude Code (claude-opus-5-5).

…gets

rule.update-rule and rule.delete-rule are open to every user in the
action seed, and the action baseline repair step (revision 7) opens them
on existing instances where the entry is still the pristine admin-only
default. Each route checks placement ownership before it reads or
writes; PermissionService::verifyPlacementOwnership() now also lets a
Nextcloud administrator through, so admins keep the right for every
dashboard.

Amends REQ-VIS-003 and REQ-VIS-004 to Ruben's decision of 21 Nov 2026.

Assisted-by: ClaudeCode:claude-opus-5-5
@rubenvdlinde
rubenvdlinde merged commit 1495c7d into development Nov 21, 2026
1 check passed
@github-actions

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/launchpad @ 1495c7d

Check PHP Vue Security License Tests
lint ✅
phpcs ❌
phpmd ❌
psalm ❌
phpstan ✅
phpmetrics ✅
eslint ✅
stylelint ✅
build ✅
check-manifest ✅
format ❌
check-schema-l10n ❌
composer ❌ ✅ 127/127
npm ✅ ✅ 647/647
app:check-code ⏭️
info.xml ✅
REUSE ❌
lockfile sync ✅
PHPUnit ❌
Newman ❌
Playwright ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development.
Hydra gates ❌

Quality workflow — 2026-11-21 17:45 UTC

Download the full PDF report from the workflow artifacts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant