Repository navigation
feat(visibility): owners change and remove the rules of their own widgets - #1489
Merged
Merged
Conversation
…gets rule.update-rule and rule.delete-rule are open to every user in the action seed, and the action baseline repair step (revision 7) opens them on existing instances where the entry is still the pristine admin-only default. Each route checks placement ownership before it reads or writes; PermissionService::verifyPlacementOwnership() now also lets a Nextcloud administrator through, so admins keep the right for every dashboard. Amends REQ-VIS-003 and REQ-VIS-004 to Ruben's decision of 21 Nov 2026. Assisted-by: ClaudeCode:claude-opus-5-5
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
November 21, 2026 14:57
Contributor
Quality Report — ConductionNL/launchpad @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ❌ | ||||
| psalm | ❌ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| format | ❌ | ||||
| check-schema-l10n | ❌ | ||||
| composer | ❌ | ✅ 127/127 | |||
| npm | ✅ | ✅ 647/647 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ | ||||
| Newman | ❌ | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-11-21 17:45 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds Ruben's answer of 21 Nov 2026: owners may also update and delete visibility rules on their own dashboards, and admins keep the right for every dashboard.
What changes:
rule.update-ruleandrule.delete-ruleare open to every user inlib/actions.seed.json. The action baseline repair step (revision 7) opens them on existing instances where the entry is still the pristine admin-only default.PermissionService::verifyPlacementOwnership()now also lets a Nextcloud administrator through, so admins keep the right for every dashboard. Before this, the check let only the owner through, admins included.openspec/specs/conditional-visibility/spec.mdnow say so, and the stale "update/delete do not verify ownership" note is removed.Verified locally: diff check green apart from gate-23 (tenant theme classes, not touched). The PermissionService phpmd findings (TooManyMethods, CouplingBetweenObjects) are identical on development.
composer check:strictonce: PHPUnit 5504 tests green; phpcs warnings, phpmd unused parameters and psalm (needs PHP 8.3.16) are inherited.Written with Claude Code (claude-opus-5-5).