Repository navigation
feat(video,divider): bump nextcloud-vue to 2.186.0, video URL parse endpoint, Configure now, one-row dividers - #1490
Merged
Conversation
…e-row dividers - POST /api/widgets/video/parse (REQ-VID-005): VideoParsingService checks that the input is an http(s) URL, recognises YouTube, Vimeo and PeerTube and answers the video id and canonical embed URL; an unusable URL is a 400 with "Invalid URL format" or "Unsupported video source". - The video form (VideoWidgetForm, over nc-vue's CnVideoWidgetForm) sends each typed URL to it and shows the error under the field, which blocks saving. - In edit mode the empty video widget offers "Configure now" (VideoHost forwards canEdit and edit; video joins EDIT_FLAG_WIDGETS). - A divider placement carries the one-row minimum its type registers, so the grid lets it be one row (REQ-DIV-006). - Dutch for the parse errors and VideoHost's two file messages. - package-lock.json repaired: it lacked @noble/hashes@2.4.0, so npm ci failed on development. Assisted-by: ClaudeCode:claude-opus-5-5
Assisted-by: ClaudeCode:claude-opus-5-5
Assisted-by: ClaudeCode:claude-opus-5-5
…tcloud-vue-widget-gaps
Assisted-by: ClaudeCode:claude-opus-5-5
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
November 21, 2026 15:01
Contributor
Quality Report — ConductionNL/launchpad @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ❌ | ||||
| psalm | ❌ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| format | ❌ | ||||
| check-schema-l10n | ❌ | ||||
| composer | ❌ | ✅ 127/127 | |||
| npm | ✅ | ✅ 647/647 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ | ||||
| Newman | ❌ | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-11-21 17:45 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings in @conduction/nextcloud-vue 2.186.0, which carries nextcloud-vue #2224–#2231, and wires the parts launchpad has to supply itself.
From the library (no launchpad code needed):
grid-layout::drag-a-widget-to-a-new-positionsave had never fired.overlayMode: "none".playlist=<id>, 9:16 fitted by height, Dutch.launchpad changes:
POST /api/widgets/video/parse(VideoParseController+VideoParsingService) checks that the input is an http(s) URL and recognises YouTube (watch, youtu.be, embed, shorts,t=offsets as?start=), Vimeo and PeerTube. A usable URL returns{isValid: true, sourceType, videoId, canonicalUrl}; an unusable one is a 400 withInvalid URL formatorUnsupported video source.@no-admin-idor-exemptbecause it takes no object id and reads no stored data.openapi.jsonis regenerated.VideoWidgetFormwraps CnVideoWidgetForm (FORM_OVERRIDESvideo). It sends each typed URL to the endpoint (300 ms debounce, latest answer wins) and passes the error to the newurlErrorprop, which shows it under the field and disables save.videojoinsEDIT_FLAG_WIDGETS, and VideoHost forwardscanEditandedit, so an empty video widget offers "Configure now" in edit mode.minHeight(withTypeMinHeightin Views.vue), so a divider can be one row (REQ-DIV-006).@e2e excludenotes for the parse endpoint scenarios are removed, and the existinginvalid-url-errore2e is tagged for them.package-lock.jsonlacked@noble/hashes@2.4.0, sonpm cifailed on development.The "File is not a video" / "Video file not found" e2e reds from the live pass were already fixed on development by 79520b2, which landed after that run.
Verified locally (CI bypassed by admin-merge on local green):
TenantTheme*classes; this PR does not touch those files.composer check:strictonce: PHPUnit 5496 tests. Its 3 failures were the missing openapi regeneration, now fixed (OpenApiDocument, Drift and RouteCoverage tests green). Inherited reds: phpcs and phpmd on untouched files, and psalm, which needs PHP ≥ 8.3.16 (box has 8.3.6).npm run lint: 0 errors.setMaxListenerson a jsdom EventTarget. I ran both sides with a local-only preload that tolerates that call (not committed): base 58 failures, this branch 57.npm run build: OK.AI-assisted (Claude Code).
🤖 Generated with Claude Code