Skip to content

feat(video,divider): bump nextcloud-vue to 2.186.0, video URL parse endpoint, Configure now, one-row dividers - #1490

Merged
rubenvdlinde merged 5 commits into
developmentfrom
chore/bump-nextcloud-vue-widget-gaps
Nov 21, 2026
Merged

rubenvdlinde merged 5 commits into
developmentfrom
chore/bump-nextcloud-vue-widget-gaps

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

Brings in @conduction/nextcloud-vue 2.186.0, which carries nextcloud-vue #2224–#2231, and wires the parts launchpad has to supply itself.

From the library (no launchpad code needed):

  • CnDashboardGrid: a drag after edit mode is turned on is saved again. The grid-layout::drag-a-widget-to-a-new-position save had never fired.
  • CnDashboardGrid: width and height changes reach the grid.
  • Calendar: agenda end times, failed-source notice, 30 s notice, Dutch.
  • Files: upload progress, per-file errors, refused-delete message, no thumbnails in tree mode.
  • Header: no stored overlayMode: "none".
  • Video: YouTube loop with playlist=<id>, 9:16 fitted by height, Dutch.
  • Add-widget picker: shows the type's icon.

launchpad changes:

  • REQ-VID-005 parse endpoint. POST /api/widgets/video/parse (VideoParseController + VideoParsingService) checks that the input is an http(s) URL and recognises YouTube (watch, youtu.be, embed, shorts, t= offsets as ?start=), Vimeo and PeerTube. A usable URL returns {isValid: true, sourceType, videoId, canonicalUrl}; an unusable one is a 400 with Invalid URL format or Unsupported video source.
    • Logged-in users only. It carries a reasoned @no-admin-idor-exempt because it takes no object id and reads no stored data.
    • openapi.json is regenerated.
  • VideoWidgetForm wraps CnVideoWidgetForm (FORM_OVERRIDES video). It sends each typed URL to the endpoint (300 ms debounce, latest answer wins) and passes the error to the new urlError prop, which shows it under the field and disables save.
  • Configure now. video joins EDIT_FLAG_WIDGETS, and VideoHost forwards canEdit and edit, so an empty video widget offers "Configure now" in edit mode.
  • Dividers. Placements carry the registry minHeight (withTypeMinHeight in Views.vue), so a divider can be one row (REQ-DIV-006).
  • Dutch for the two parse errors and VideoHost's "Video file not found" and "File is not a video".
  • Spec. The two "never built" @e2e exclude notes for the parse endpoint scenarios are removed, and the existing invalid-url-error e2e is tagged for them.
  • Lock repair. package-lock.json lacked @noble/hashes@2.4.0, so npm ci failed on development.

The "File is not a video" / "Video file not found" e2e reds from the live pass were already fixed on development by 79520b2, which landed after that run.

Verified locally (CI bypassed by admin-merge on local green):

  • diff-check: phpcs, phpstan, phpunit, eslint and stylelint PASS. Its one gates finding is gate-23, which flags the app-local TenantTheme* classes; this PR does not touch those files.
  • composer check:strict once: PHPUnit 5496 tests. Its 3 failures were the missing openapi regeneration, now fixed (OpenApiDocument, Drift and RouteCoverage tests green). Inherited reds: phpcs and phpmd on untouched files, and psalm, which needs PHP ≥ 8.3.16 (box has 8.3.6).
  • New PHPUnit: 20 tests, green.
  • npm run lint: 0 errors.
  • Full vitest against clean development: no new failing files, one more file passing.
    • On this box 98 files fail on clean development as well, because p-queue calls setMaxListeners on a jsdom EventTarget. I ran both sides with a local-only preload that tolerates that call (not committed): base 58 failures, this branch 57.
  • npm run build: OK.

AI-assisted (Claude Code).

🤖 Generated with Claude Code

…e-row dividers

- POST /api/widgets/video/parse (REQ-VID-005): VideoParsingService checks
  that the input is an http(s) URL, recognises YouTube, Vimeo and PeerTube
  and answers the video id and canonical embed URL; an unusable URL is a 400
  with "Invalid URL format" or "Unsupported video source".
- The video form (VideoWidgetForm, over nc-vue's CnVideoWidgetForm) sends
  each typed URL to it and shows the error under the field, which blocks
  saving.
- In edit mode the empty video widget offers "Configure now" (VideoHost
  forwards canEdit and edit; video joins EDIT_FLAG_WIDGETS).
- A divider placement carries the one-row minimum its type registers, so
  the grid lets it be one row (REQ-DIV-006).
- Dutch for the parse errors and VideoHost's two file messages.
- package-lock.json repaired: it lacked @noble/hashes@2.4.0, so npm ci
  failed on development.

Assisted-by: ClaudeCode:claude-opus-5-5
Assisted-by: ClaudeCode:claude-opus-5-5
Assisted-by: ClaudeCode:claude-opus-5-5
Assisted-by: ClaudeCode:claude-opus-5-5
@rubenvdlinde
rubenvdlinde merged commit 4781688 into development Nov 21, 2026
8 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/launchpad @ cb34a8e

Check PHP Vue Security License Tests
lint ✅
phpcs ❌
phpmd ❌
psalm ❌
phpstan ✅
phpmetrics ✅
eslint ✅
stylelint ✅
build ✅
check-manifest ✅
format ❌
check-schema-l10n ❌
composer ❌ ✅ 127/127
npm ✅ ✅ 647/647
app:check-code ⏭️
info.xml ✅
REUSE ❌
lockfile sync ✅
PHPUnit ❌
Newman ❌
Playwright ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development.
Hydra gates ❌

Quality workflow — 2026-11-21 17:45 UTC

Download the full PDF report from the workflow artifacts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant