Skip to content

feat(launchpad): pick dashboard hierarchies in the settings - #1496

Merged
rubenvdlinde merged 2 commits into
developmentfrom
feat/drill-down-cross-widget-filter-hierarchy-settings
Nov 21, 2026
Merged

rubenvdlinde merged 2 commits into
developmentfrom
feat/drill-down-cross-widget-filter-hierarchy-settings

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

What

The second half of REQ-CWF-011 (drill-down-cross-widget-filter): dashboard owners and editors pick the hierarchies their filter bus uses.

  • src/utils/hierarchyPresets.js: the nl-administrative preset (province > municipality > district: provincieCode > gemeenteCode > wijkCode) as configuration. The stored labels are the English source strings; readers see the preset's labels in their own language.
  • Dashboard settings (Details): a "Drill-down levels" picker over the presets. A stored hierarchy that is no preset stays in the list, so saving does not drop it. The hierarchies are sent only when the choice changed, so a metadata-only editor's save never carries them.
  • Views.saveDashboardConfig passes them through and, when the open dashboard changed, rebuilds its filter session on what it now stores (openFilterSession(false)).
  • levelLabels() uses a preset's translated labels for its levels.
  • nl and en strings; tasks 38-40 ticked; the stale "not stored yet" note on Task 10 updated.
  • e2e: the owner picks the preset in the settings modal (dashboard-hierarchies.spec.ts).

Board note: LpDashboardInstellingen does not draw a drill-down field yet. The picker sits in the Details tab under "Opens in", in the same field style. The board needs this field drawn, or a decision on where it belongs.

Verified locally (merged on local green)

  • hydra/scripts/diff-check.sh: no NEW findings in units, eslint, stylelint. A first run flagged saveDashboardConfig over McCabe 10; the update body moved into dashboardUpdateData(). Gates: the same inherited gate-23 finding as feat(launchpad): dashboards store their filter hierarchies #1495 (app-local TenantTheme* classes, untouched).
  • composer check:strict once: PHPUnit 5555 OK (no PHP changed here), same inherited phpcs/phpmd as feat(launchpad): dashboards store their filter hierarchies #1495, psalm cannot run on PHP 8.3.6. npm run lint exits 0.
  • vitest: hierarchyPresets, useDashboardFilterSession, DashboardConfigModal.hierarchies, DashboardConfigModal.linkTarget, ActiveFiltersPanel, useFilterBus, chartAndStatsHosts: 7 files, 56 tests pass.
  • Views.look.spec.js (where the Views save test lives) does not load on this host under Node 20, 22 or 24, on development too: @nextcloud/vue's nested p-queue throws "eventTargets" argument must be an instance of EventEmitter on import. That is inherited, and it blocks every spec that imports @nextcloud/vue unmocked (28 suites in the renderers folder). CI decides on that test.
  • eslint clean on the touched files.

AI assistance: built with Claude Code (claude-opus-5-5).

The nl-administrative hierarchy (province > municipality > district)
ships as a preset in src/utils/hierarchyPresets.js. The dashboard
settings gain a "Drill-down levels" picker over the presets that keeps
any other stored hierarchy, and send the hierarchies only when the
choice changed. After a save that changes them, the open dashboard's
filter session is rebuilt on what it now stores, and a preset's level
labels follow the reader's language. Strings in nl and en; tasks 38-40
ticked.

Assisted-by: ClaudeCode:claude-opus-5-5
Keeps saveDashboardConfig under the complexity bound now that it also
sends the hierarchies.

Assisted-by: ClaudeCode:claude-opus-5-5
@rubenvdlinde
rubenvdlinde merged commit 8e53334 into development Nov 21, 2026
1 check passed
@github-actions

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/launchpad @ 46ea61d

Check PHP Vue Security License Tests
lint ✅
phpcs ❌
phpmd ❌
psalm ❌
phpstan ✅
phpmetrics ✅
eslint ✅
stylelint ✅
build ✅
check-manifest ✅
format ❌
check-schema-l10n ❌
composer ❌ ✅ 127/127
npm ✅ ✅ 647/647
app:check-code ⏭️
info.xml ✅
REUSE ❌
lockfile sync ✅
PHPUnit ❌
Newman ❌
Playwright ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development.
Hydra gates ❌

Quality workflow — 2026-11-21 19:46 UTC

Download the full PDF report from the workflow artifacts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant