Repository navigation
feat(launchpad): pick dashboard hierarchies in the settings - #1496
Merged
rubenvdlinde merged 2 commits intoNov 21, 2026
Merged
rubenvdlinde merged 2 commits into
rubenvdlinde merged 2 commits into
Conversation
The nl-administrative hierarchy (province > municipality > district) ships as a preset in src/utils/hierarchyPresets.js. The dashboard settings gain a "Drill-down levels" picker over the presets that keeps any other stored hierarchy, and send the hierarchies only when the choice changed. After a save that changes them, the open dashboard's filter session is rebuilt on what it now stores, and a preset's level labels follow the reader's language. Strings in nl and en; tasks 38-40 ticked. Assisted-by: ClaudeCode:claude-opus-5-5
Keeps saveDashboardConfig under the complexity bound now that it also sends the hierarchies. Assisted-by: ClaudeCode:claude-opus-5-5
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
November 21, 2026 18:46
Contributor
Quality Report — ConductionNL/launchpad @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ❌ | ||||
| psalm | ❌ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| format | ❌ | ||||
| check-schema-l10n | ❌ | ||||
| composer | ❌ | ✅ 127/127 | |||
| npm | ✅ | ✅ 647/647 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ | ||||
| Newman | ❌ | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-11-21 19:46 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The second half of REQ-CWF-011 (drill-down-cross-widget-filter): dashboard owners and editors pick the hierarchies their filter bus uses.
src/utils/hierarchyPresets.js: thenl-administrativepreset (province > municipality > district:provincieCode>gemeenteCode>wijkCode) as configuration. The stored labels are the English source strings; readers see the preset's labels in their own language.Views.saveDashboardConfigpasses them through and, when the open dashboard changed, rebuilds its filter session on what it now stores (openFilterSession(false)).levelLabels()uses a preset's translated labels for its levels.dashboard-hierarchies.spec.ts).Board note: LpDashboardInstellingen does not draw a drill-down field yet. The picker sits in the Details tab under "Opens in", in the same field style. The board needs this field drawn, or a decision on where it belongs.
Verified locally (merged on local green)
hydra/scripts/diff-check.sh: no NEW findings in units, eslint, stylelint. A first run flaggedsaveDashboardConfigover McCabe 10; the update body moved intodashboardUpdateData(). Gates: the same inherited gate-23 finding as feat(launchpad): dashboards store their filter hierarchies #1495 (app-localTenantTheme*classes, untouched).composer check:strictonce: PHPUnit 5555 OK (no PHP changed here), same inherited phpcs/phpmd as feat(launchpad): dashboards store their filter hierarchies #1495, psalm cannot run on PHP 8.3.6.npm run lintexits 0.hierarchyPresets,useDashboardFilterSession,DashboardConfigModal.hierarchies,DashboardConfigModal.linkTarget,ActiveFiltersPanel,useFilterBus,chartAndStatsHosts: 7 files, 56 tests pass.Views.look.spec.js(where the Views save test lives) does not load on this host under Node 20, 22 or 24, ondevelopmenttoo:@nextcloud/vue's nestedp-queuethrows"eventTargets" argument must be an instance of EventEmitteron import. That is inherited, and it blocks every spec that imports@nextcloud/vueunmocked (28 suites in the renderers folder). CI decides on that test.AI assistance: built with Claude Code (claude-opus-5-5).