Skip to content

feat(launchpad): copies of a dashboard keep its hierarchies - #1500

Merged
rubenvdlinde merged 5 commits into
developmentfrom
feat/drill-down-cross-widget-filter-copy-hierarchies
Nov 21, 2026
Merged

rubenvdlinde merged 5 commits into
developmentfrom
feat/drill-down-cross-widget-filter-copy-hierarchies

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

What

Ruben decided on 21 Nov that copies of a dashboard keep its hierarchies (REQ-CWF-011):

  • Duplicate (fork): DashboardService::persistFork() copies the source's hierarchies.
  • Template: TemplateService::buildDashboardFromTemplate() copies the template's hierarchies onto the dashboard made from it.
  • Import: export already wrote hierarchies (it serialises the whole dashboard). ImportService::applyEntityHierarchies() reads them back, validated like an API update through DashboardHierarchies::validated(). A malformed list is left out with a warning, so the rest of the dashboard still lands.
  • Spec: new scenario "Copies keep the hierarchies" and Task 42 (ticked).
  • Tests:
    • DashboardHierarchiesCopyTest.php: template, export then import, malformed archive.
    • DashboardServiceForkTest::testForkKeepsTheSourcesHierarchies.
    • e2e cross-widget-filter::copies-keep-the-hierarchies in dashboard-hierarchies.spec.ts: a fork, and an export imported again through /api/admin/import.

Verified locally (merged on local green)

  • diff-check: no NEW findings in php -l, phpcs, phpstan, phpmd, phpunit, eslint, units. Gates: the same inherited gate-23 finding as feat(launchpad): dashboards store their filter hierarchies #1495 (TenantTheme*).
  • composer check:strict once: PHPUnit 5559 tests OK (13 skipped), phpstan OK, spec-annotations OK. The phpcs and phpmd findings are on lines I did not touch (for example the UuidV4 static access in TemplateService). Psalm needs PHP 8.3.16 and cannot run here. npm run lint: exit 0.
  • development was merged in after the suite. It brought only the nextcloud-vue 2.186.1 bump (package files and SBOM), no PHP.
  • The e2e tests were not run here; the live-pass lane runs them.

AI assistance: built with Claude Code (claude-opus-5-5).

A fork, a dashboard made from a template and an imported dashboard now
keep the source's hierarchies (REQ-CWF-011), as Ruben decided on 21
Nov. Export already wrote them; the importer validates them like an API
update and leaves a malformed list out with a warning. New scenario
"Copies keep the hierarchies" and task 42; unit tests per path and an
e2e test for the fork and the export-import round trip.

Assisted-by: ClaudeCode:claude-opus-5-5
…tatically

Assisted-by: ClaudeCode:claude-opus-5-5
Assisted-by: ClaudeCode:claude-opus-5-5
@rubenvdlinde
rubenvdlinde merged commit c0ee0b2 into development Nov 21, 2026
1 check passed
@github-actions

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/launchpad @ 5a1641e

Check PHP Vue Security License Tests
lint ✅
phpcs ❌
phpmd ❌
psalm ❌
phpstan ✅
phpmetrics ✅
eslint ✅
stylelint ✅
build ✅
check-manifest ✅
format ❌
check-schema-l10n ❌
composer ❌ ✅ 127/127
npm ✅ ✅ 647/647
app:check-code ⏭️
info.xml ✅
REUSE ❌
lockfile sync ✅
PHPUnit ❌
Newman ❌
Playwright ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development.
Hydra gates ❌

Quality workflow — 2026-11-21 21:10 UTC

Download the full PDF report from the workflow artifacts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant