Repository navigation
feat(launchpad): copies of a dashboard keep its hierarchies - #1500
Merged
rubenvdlinde merged 5 commits intoNov 21, 2026
Merged
rubenvdlinde merged 5 commits into
rubenvdlinde merged 5 commits into
Conversation
A fork, a dashboard made from a template and an imported dashboard now keep the source's hierarchies (REQ-CWF-011), as Ruben decided on 21 Nov. Export already wrote them; the importer validates them like an API update and leaves a malformed list out with a warning. New scenario "Copies keep the hierarchies" and task 42; unit tests per path and an e2e test for the fork and the export-import round trip. Assisted-by: ClaudeCode:claude-opus-5-5
…n-cross-widget-filter-copy-hierarchies
…tatically Assisted-by: ClaudeCode:claude-opus-5-5
Assisted-by: ClaudeCode:claude-opus-5-5
…n-cross-widget-filter-copy-hierarchies
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
November 21, 2026 20:15
Contributor
Quality Report — ConductionNL/launchpad @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ❌ | ||||
| psalm | ❌ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| format | ❌ | ||||
| check-schema-l10n | ❌ | ||||
| composer | ❌ | ✅ 127/127 | |||
| npm | ✅ | ✅ 647/647 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ | ||||
| Newman | ❌ | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-11-21 21:10 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Ruben decided on 21 Nov that copies of a dashboard keep its
hierarchies(REQ-CWF-011):DashboardService::persistFork()copies the source's hierarchies.TemplateService::buildDashboardFromTemplate()copies the template's hierarchies onto the dashboard made from it.hierarchies(it serialises the whole dashboard).ImportService::applyEntityHierarchies()reads them back, validated like an API update throughDashboardHierarchies::validated(). A malformed list is left out with a warning, so the rest of the dashboard still lands.DashboardHierarchiesCopyTest.php: template, export then import, malformed archive.DashboardServiceForkTest::testForkKeepsTheSourcesHierarchies.cross-widget-filter::copies-keep-the-hierarchiesindashboard-hierarchies.spec.ts: a fork, and an export imported again through/api/admin/import.Verified locally (merged on local green)
TenantTheme*).composer check:strictonce: PHPUnit 5559 tests OK (13 skipped), phpstan OK, spec-annotations OK. The phpcs and phpmd findings are on lines I did not touch (for example theUuidV4static access inTemplateService). Psalm needs PHP 8.3.16 and cannot run here.npm run lint: exit 0.developmentwas merged in after the suite. It brought only the nextcloud-vue 2.186.1 bump (package files and SBOM), no PHP.AI assistance: built with Claude Code (claude-opus-5-5).