Repository navigation
Release: merge development into beta - #772
Open
github-actions[bot] wants to merge 1841 commits into
Open
github-actions[bot] wants to merge 1841 commits into
github-actions[bot] wants to merge 1841 commits into
Conversation
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48,
rjzondervan and
rubenvdlinde
as code owners
October 5, 2026 16:36
Comment on lines
+58
to
+59
| return wrapper.find('.dashboard-switcher-sidebar__body').html() | ||
| .replace(/<!--[\s\S]*?-->/g, '') |
| return null | ||
| } | ||
| return grid.querySelector( | ||
| `.launchpad-grid-item[data-placement-id="${placementId.replace(/"/g, '\\"')}"]`, |
| cell(page, placement).locator('a.tile-widget__link'), | ||
| ).toHaveAttribute( | ||
| 'href', | ||
| new RegExp(`^${want.link!.replace(/[.]/g, '\\.')}/?$`), |
| await page | ||
| .locator('.vs__dropdown-option') | ||
| .filter({ | ||
| hasText: new RegExp(`^\\s*${option.replace(/[()]/g, '\\$&')}\\s*$`), |
| // …and each file says where it is in the queue. | ||
| for (const name of [`big-${RUN}.bin`, `small-${RUN}.txt`]) { | ||
| await expect.soft( | ||
| widget.getByText(new RegExp(`${name.replace(/\./g, '\\.')}`)).filter({ hasText: /queued|in progress|uploading|completed|uploaded|done/i }).first(), |
|
|
||
| // path is relative to the widget root, not the storage-internal path. | ||
| for (const item of body.items) { | ||
| expect(item.path, JSON.stringify(item)).toMatch(new RegExp(`^/?${item.name.replace(/\./g, '\\.')}$`)) |
| expect(await rolesOf(admin, { userId: bob.username })).toEqual([]) | ||
|
|
||
| // The id is free again; a fresh account under it must not inherit a role. | ||
| const password = `Probe-${Math.random().toString(36).slice(2)}A1!` |
| test("a deleted user's analytics opt-out does not survive for a new account with the same id", async () => { | ||
| // @e2e dashboard-cascade-events::analytics-opt-out-preference-is-removed-on-user-deletion | ||
| const username = `e2e-cascade-optout-${Date.now()}` | ||
| const password = `Probe-${Math.random().toString(36).slice(2)}A1!` |
| for (let i = 0; i < 150; i++) { | ||
| members.push({ | ||
| username: `e2e-rxn-p${i}-${RUN}`, | ||
| password: `Probe-${Math.random().toString(36).slice(2)}A1!`, |
| admin: APIRequestContext, | ||
| created: CreatedGroupDashboard[], | ||
| ): Promise<void> { | ||
| for (const { groupId, uuid } of created) { |
…set folder The asset-folder timestamp had second resolution, so two runs of the same archive started within a second reported the same folder, which REQ-CFLI-010 forbids. The segment now carries microseconds. Assisted-by: ClaudeCode:claude-opus-5-5
…rowaway account Both built their "account" context with httpCredentials on a context that inherited the admin storageState cookie, so the account's dashboards were created on admin. The deep-link test then opened the throwaway account's workspace and found no row for a dashboard it never owned. Use contextFor/adminContext, which always send basic auth and carry no session. Assisted-by: ClaudeCode:claude-opus-5-5
…icker's own button "Nothing to manage children with" matched any button named add or remove, which caught the background colour picker's "Remove color" button in the communal form. That button clears a colour, not a child. Assisted-by: ClaudeCode:claude-opus-5-5
…creen at once Forgetting recomputed the sorted order and Vue rewrote the gs-x/gs-y attributes, but GridStack keeps its own copy of each item's position, so the tiles stayed where they were until a reload. After forgetting, the inner grid is told to move every item to the position its attributes now name. Assisted-by: ClaudeCode:claude-opus-5-5
innerText follows the rendered line breaks, and the narrow dropdown
wraps every zone name ("Africa/\nAbidjan"), so no name matched
Europe/Amsterdam. textContent reads the option as it is.
Assisted-by: ClaudeCode:claude-opus-5-5
…efault widget rule The throwaway account is in no group, so the `default` widget rule decides what it may place. Specs that call ensureDefaultWidgetRestriction leave that rule at activity and recommendations only, and every grid-layout spec then failed in beforeAll with 403 on its first text widget. The fixture now lifts the rule for the account's lifetime and restores it on teardown, like the personal-dashboards flag next to it. Assisted-by: ClaudeCode:claude-opus-5-5
…ud timezone REQ-CLOCK-002 defaults an unset clock to the user's Nextcloud timezone, but the widget used the device zone, so someone whose account says Tokyo read Los Angeles time on a laptop set to it. The workspace page now hands the user's core/timezone over in its initial state (optional key userTimezone) and the clock uses it when it names no zone of its own. A public page has no user and keeps the device zone. The clock still fetches nothing. Assisted-by: ClaudeCode:claude-opus-5-5
…an appear WorkspaceApp mounts OrgNavigationPanel only when the store holds a visible position and a non-empty tree, but the only workspace code that fetched them was the panel's own mounted(). The panel therefore never mounted and the rail never showed (navigation-editor-org REQ-ONAV-004/005). The shell now loads position and tree on mount; the panel no longer fetches, so a rendered rail does not load them twice. Assisted-by: ClaudeCode:claude-opus-5-5
The relative date used one plural string per unit, so a count of one read "1 days ago" / "1 hours ago" / "1 minutes ago" (news-widget scenario: relative dates read "2 hours ago" / "1 day ago"). A count of one now uses its own singular string, the same pattern as "1 feed failed", with the Dutch translation added. Assisted-by: ClaudeCode:claude-opus-5-5
…extcloud 34 Three fixes to the spec, none to the product: - widgets are placed by the dashboard's owner; the admin may not add widgets to someone else's personal dashboard and got 403; - the header trigger is Nextcloud 34's `.unified-search-input__button`, which the old `#unified-search button` locator no longer finds; - the description-match scenario asserted a creation/widget-count subline (REQ-SRCH-002), while REQ-SRCH-006 and the product put the description there; the stricter requirement wins. Assisted-by: ClaudeCode:claude-opus-5-5
Nextcloud 34's dispatcher range-checks every int parameter named `limit` against 1..500 unless the method declares a psalm int range, and throws an unhandled ParameterOutOfRangeException (a 500) for limit=0 or -1 before newsItems() runs. The method now declares an unbounded range, so its own 1..50 check answers 400 as REQ-NEWS-003 says. Assisted-by: ClaudeCode:claude-opus-5-5
…eSidebar skips a closed sidebar The three news spec files ran in serial mode, so the first failure skipped every later scenario in the file (41 "did not run"). Each test cleans its own placements and the suite runs on one worker, so default mode keeps the order and the shared dashboard while reporting every scenario on its own. closeSidebar clicked the switcher's close button whenever it was "visible"; a closed sidebar stays in the DOM slid out of the viewport, so the click timed out with "element is outside of the viewport". It now only closes an open sidebar. Assisted-by: ClaudeCode:claude-opus-5-5
Nextcloud rate-limits account edits per acting user (editUser: 50 per 10 minutes). The people specs provisioned every person by editing it as the admin, so after a few files the admin's budget ran out and setup failed with 429. Each throwaway account now edits its own display name and email, which also matches how a person fills in their profile. Assisted-by: ClaudeCode:claude-opus-5-5
…rgest limit allowed The top-dashboards and top-tiles endpoints declare limit in 1..500 and Nextcloud's dispatcher answers 500 for anything outside the range, so the three limit=1000 reads failed before LaunchPad was reached. Assisted-by: ClaudeCode:claude-opus-5-5
…fits its preset REQ-HDR-009 "Default grid sizing for header widget": a new header's gridWidth is the dashboard's column count and its gridHeight follows the height preset and the 60px row. Every custom widget started at the default 4x4, so a header came in a third of the width. Assisted-by: ClaudeCode:claude-opus-5-5
…ts by their name - A new dashboard carries the default bundle (three tiles and a files widget); the header suite now clears it so the grid holds only the headers a test places. - The keyboard test counted focus on <body> as reaching the widget, because body contains the heading. - A single-value NcSelect in @nextcloud/vue 9 renders no label.select__label; the form's selects are found by their combobox's accessible name. Assisted-by: ClaudeCode:claude-opus-5-5
DashboardService refused a non-owner's update or delete with a bare Exception, which the controller turned into 400 "Operation failed". A refusal is a 403: the service now throws ForbiddenException and the update and delete actions answer it with the forbidden envelope. Who is refused does not change. Assisted-by: ClaudeCode:claude-opus-5-5
…al switch off REQ-ASET-003 says the allow-user-dashboards switch never restricts a Nextcloud administrator, but POST /api/dashboard ran the switch before anything else and answered an admin 403 personal_dashboards_disabled. The create guard now lets an administrator past the switch; everyone else is gated as before. Assisted-by: ClaudeCode:claude-opus-5-5
… may be resized to one row REQ-DIV-006: a divider added through the modal was created at the 4x4 every widget gets, and the move/resize panel stopped shrinking at two rows. A new widget now takes its size from defaultSizeFor(type), which gives a divider every column and one row, and nudgePlacement lets a divider (ONE_ROW_TYPES) shrink to one row. Assisted-by: ClaudeCode:claude-opus-5-5
Assisted-by: ClaudeCode:claude-opus-5-5
…tcloud-vue-widget-gaps
…gets rule.update-rule and rule.delete-rule are open to every user in the action seed, and the action baseline repair step (revision 7) opens them on existing instances where the entry is still the pristine admin-only default. Each route checks placement ownership before it reads or writes; PermissionService::verifyPlacementOwnership() now also lets a Nextcloud administrator through, so admins keep the right for every dashboard. Amends REQ-VIS-003 and REQ-VIS-004 to Ruben's decision of 21 Nov 2026. Assisted-by: ClaudeCode:claude-opus-5-5
feat(visibility): owners change and remove the rules of their own widgets
Assisted-by: ClaudeCode:claude-opus-5-5
…idget-gaps feat(video,divider): bump nextcloud-vue to 2.186.0, video URL parse endpoint, Configure now, one-row dividers
Tasks 10 and 35 of drill-down-cross-widget-filter need the 300 ms bound, the query time and the bus's memory cost measured on a populated OpenRegister. cwfPerfSeed.ts generates a fixed data set along the Dutch administrative hierarchy (12 provinces, 342 gemeenten, about 3,000 wijken, 50,000 objects) and seeds it through OpenRegister's bulk save; cwfPerfSeed.cli.mts runs the seed or removes it. cross-widget-filter-performance.spec.ts builds a dashboard with a gemeente chart that publishes, a wijk chart and a status chart that consume, and a chart that consumes nothing, then clicks a gemeente and its largest wijk twelve times. It measures, in the page's clock, the press to each consumer showing the filtered data, the OpenRegister time of every filtered request, and checks the non-consumer neither asks nor redraws. It runs once with `bar-list` charts and once with ApexCharts bars, so the drawing cost is told apart from the bus and the query. A third test compares the heap of 110 charts on and off the bus. Every number is attached as JSON. The tests skip without the data set. Dashboards do not store hierarchy descriptors yet, so the spec adds the hierarchy to the dashboard read. Assisted-by: ClaudeCode:claude-opus-5-5
…10 open Both tasks asked for profiling on a production OpenRegister cluster; they now name a representative local stack with its volume recorded, and carry the numbers of the performance spec (50,000 objects, 12 clicks per chart kind). Only consumers refetch, OpenRegister answers the drill-down queries in 108-153 ms median, and the bus costs 0.32 MB of heap for 110 charts. The 300 ms bound holds with `bar-list` charts (p95 244 ms) and is missed with ApexCharts bars (median 9.8 s), almost all of it the chart redraw, so Task 10 stays open on that. Task 35 is done: the numbers are recorded and a re-render over 200 ms logs a warning. The results are a comment on `openFilterSession()` in Views.vue, the dashboard view (there is no Dashboard.vue). Assisted-by: ClaudeCode:claude-opus-5-5
Every test of these specs ran in the live pass rerun on development and passed (4.14 keeps its fixme for a requirement never built). Assisted-by: ClaudeCode:claude-opus-5-5
…-ticks-3 chore(openspec): tick eight programme tasks that ran fully green
…-drilldown-perf feat(launchpad): stats blocks follow the filter bus, slow refetches are logged, drill-down performance measured
A dashboard now stores the hierarchy descriptors its filter bus joins
widgets on (REQ-CWF-011): a nullable `hierarchies` JSON column on
launchpad_dashboards, returned on the owner and viewer reads as a list
([] when none). PUT /api/dashboard/{id} accepts `hierarchies`, which
needs the full edit permission like a layout change; the new
DashboardHierarchies validator refuses a malformed descriptor with 400
before anything is saved and derives each level's parent from the level
above. openapi documents the field; the goldens carry the new wire
field. The change gets REQ-CWF-011 and tasks 36-41.
Assisted-by: ClaudeCode:claude-opus-5-5
tests/e2e/dashboard-hierarchies.spec.ts covers REQ-CWF-011 through the dashboard API: stored and read back, refused when malformed or sent by a view-only recipient, cleared by an empty list, and read by the filter bus of the open dashboard. The performance spec stores the nl-administrative hierarchy through the API instead of adding it to the dashboard read. Assisted-by: ClaudeCode:claude-opus-5-5
Assisted-by: ClaudeCode:claude-opus-5-5
…et-filter-stored-hierarchies feat(launchpad): dashboards store their filter hierarchies
The nl-administrative hierarchy (province > municipality > district) ships as a preset in src/utils/hierarchyPresets.js. The dashboard settings gain a "Drill-down levels" picker over the presets that keeps any other stored hierarchy, and send the hierarchies only when the choice changed. After a save that changes them, the open dashboard's filter session is rebuilt on what it now stores, and a preset's level labels follow the reader's language. Strings in nl and en; tasks 38-40 ticked. Assisted-by: ClaudeCode:claude-opus-5-5
Keeps saveDashboardConfig under the complexity bound now that it also sends the hierarchies. Assisted-by: ClaudeCode:claude-opus-5-5
…et-filter-hierarchy-settings feat(launchpad): pick dashboard hierarchies in the settings
Brings the in-place, unanimated chart update (nextcloud-vue #2232). Assisted-by: ClaudeCode:claude-opus-5-5
The preset runs province > municipality > district > neighbourhood (buurtCode under wijkCode), as Ruben decided on 21 Nov. nl and en labels; spec, task note, tests and the e2e descriptor follow. Assisted-by: ClaudeCode:claude-opus-5-5
Assisted-by: ClaudeCode:claude-opus-5-5
A fork, a dashboard made from a template and an imported dashboard now keep the source's hierarchies (REQ-CWF-011), as Ruben decided on 21 Nov. Export already wrote them; the importer validates them like an API update and leaves a malformed list out with a warning. New scenario "Copies keep the hierarchies" and task 42; unit tests per path and an e2e test for the fork and the export-import round trip. Assisted-by: ClaudeCode:claude-opus-5-5
…et-filter-buurt-level feat(launchpad): add neighbourhood to the nl-administrative preset
…n-cross-widget-filter-copy-hierarchies
…tatically Assisted-by: ClaudeCode:claude-opus-5-5
Assisted-by: ClaudeCode:claude-opus-5-5
…tcloud-vue-2.186.1
….186.1 chore(deps): bump @conduction/nextcloud-vue to 2.186.1
…n-cross-widget-filter-copy-hierarchies
…et-filter-copy-hierarchies feat(launchpad): copies of a dashboard keep its hierarchies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated PR to sync development changes to beta for beta release.
Merging this PR will trigger the beta release workflow.