Repository navigation
refactor(architecture): count Kernel files only Core uses to Core (X95, part 1) - #10992
Merged
Merged
Conversation
The events, bulk-save outcomes and refusals that only Core dispatches, throws or catches are Core's work: their csv rows move from Kernel to Core (kernel.md K5-01, Appendix A "To Core"). The organisation events and their abstract base move with them; the three concrete events stay exposed from Core, since Integrations and Processes listen. FolderAccessDeniedException, LockedException and UniqueHintException stay in Kernel: Files, Compliance and Search now name them too. Assisted-by: ClaudeCode:claude-opus-5-5
…re's Kernel files to Core Assisted-by: ClaudeCode:claude-opus-5-5
…#10992 Assisted-by: ClaudeCode:claude-opus-5-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Package X95 (K-rows), part 1 of 3: kernel.md K5-01, Appendix A "To Core".
What moved and why
Kernel files that only Core dispatches, throws, catches or builds now count to Core, by their row in
scripts/component-map.csv(no file moves, no code change). These are Core's own events (custom scope, action evaluation, reference validation, registry subscription, relation decision, user profile, matrix rows, identity claims, object activation), the bulk-save outcome types,ObjectEventSubscription,OasValidationReportInterfaceand Core's write, schema and RBAC refusals. The organisation events and their baseAbstractOrganisationEventmove too: Core dispatches them, so they are Core's work; the three concrete events stay exposed from Core because Integrations and Processes listen, which is the allowed direction. FourDto/files that fell under the directory row got a file row.Dto/BulkRowCount.php,Dto/BulkSaveOutcome.php,Dto/BulkSaveOutcomeInterface.php,Dto/BulkSaveOutcomes.php,Dto/StreamedRowCount.php,Event/AbstractOrganisationEvent.php,Event/AbstractReferenceValidationEvent.php,Event/AbstractRegistrySubscriptionEvent.php,Event/ActionEvaluatedEvent.php,Event/CustomScopeAccessors.php,Event/CustomScopeEvaluatedEvent.php,Event/CustomScopeEvaluatingEvent.php,Event/EntityRelationDecisionUpdatedEvent.php,Event/EvaluatedSchemaActionAccessors.php,Event/IdentityClaimsCollectingEvent.php,Event/MatrixRowsRequestedEvent.php,Event/ObjectActivatedEvent.php,Event/ObjectEventSubscription.php,Event/OrganisationCreatedEvent.php,Event/OrganisationDeletedEvent.php,Event/OrganisationUpdatedEvent.php,Event/ReferenceValidatedEvent.php,Event/ReferenceValidationFailedEvent.php,Event/RegistrySubscriptionEndedEvent.php,Event/RegistrySubscriptionRequestedEvent.php,Event/UserProfileUpdatedEvent.php,Exception/AppendOnlyException.php,Exception/ArchiveNotOfferedException.php,Exception/AuthorizationBlockException.php,Exception/BreakingSchemaChangeException.php,Exception/BrokenReference.php,Exception/CircularReferenceException.php,Exception/CodedValueException.php,Exception/DatabaseConstraintException.php,Exception/DatabaseConstraintMessages.php,Exception/DraftActivationRefusedException.php,Exception/EncryptedFieldSortException.php,Exception/FieldDecryptionException.php,Exception/GrantExceedsGranterException.php,Exception/InvalidAuthorizationRuleException.php,Exception/OasValidationException.php,Exception/ObjectLookupFailedException.php,Exception/OrganisationSlugConflictException.php,Exception/ReadOnlyTypeException.php,Exception/ReferenceCycle.php,Exception/ReferenceValidationException.php,Exception/SchemaImportException.php,Exception/SchemaNotFoundException.php,Exception/SchemaRunConcurrencyException.php,Exception/SearchTermSyntaxException.php,Exception/SharedMasterDataWriteException.php,Exception/SlugBackfillWriteException.php,Exception/SystemContextUnavailableException.php,Exception/TranslationTargetConflictException.php,Exception/ViewAlertRecipientException.php,Service/Oas/OasValidationReportInterface.phpRe-measured on main
b85c154eException/FolderAccessDeniedException(now also named by Files),Exception/LockedException(also Compliance) andException/UniqueHintException(also Search). They are shared by several areas since the Kernel plan was written, so they stay in Kernel; moving them would only shift the exposure to Core.Exposed lines per area (main → this PR)
Expected in the package file for all three parts together: Kernel 8,571 → 5,984 (−2,587). Measured for this part: Kernel −1,082, Core +32, total −1,050.
References against the order
38 before, 38 after. No newly exposed file, no new Kernel file.
Modularity baseline
Re-recorded with
--write-baseline: 46 entries ofexposed_filesand 56 ofkernel_filesgone (the moved files),exposed_locKernel 8,464 → 7,382 and Core 57,319 → 57,351,kernel_loc10,402 → 9,044.against_orderand the violation degree (0.0049) are unchanged.What ran
php -l, phpcs, psalm: no PHP file changed (the diff is the csv, the two files generated from it and the modularity baseline), so nothing to lint.lib:lib/is byte-identical to mainb85c154e;vendor/bin/phpstan analyse --no-progressreports the same 37 errors main has, none new.python3 scripts/component-patterns.pyanddeptrac_areas.pyregenerated the two generated files;component-patterns.py --checkpasses (only the stale-row notices main already prints).--check: passed against main's baseline before re-recording (gone entries only, no newly exposed file, no new Kernel file, no new reference against the order); passes after--write-baseline.--check: passed, 39 class pairs in violation as recorded (its "851 gone" notice is the same on main; the deptrac baseline is left to the coordinator).vendor/bin/phpunit --no-coverage tests/Unit/Architecture(all of it, run in two halves): OK, 2,371 tests, 8,057 assertions.tests/Unitis run once per package, on its last PR (part 3).Land first; parts 2 and 3 stack on this branch.
Written with Claude Code (claude-opus-5-5)
Generated by Claude Code