Skip to content

refactor(architecture): count Kernel files only Processes uses to Processes (X95, part 2) - #10993

Merged
rubenvdlinde merged 4 commits into
mainfrom
cloud/mod-X95-processes-rows
Nov 21, 2026
Merged

rubenvdlinde merged 4 commits into
mainfrom
cloud/mod-X95-processes-rows

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

Package X95 (K-rows), part 2 of 3: kernel.md K5-02, Appendix A "To Processes".

Stacked on part 1 (cloud/mod-X95-core-rows): both parts edit the same rows file and the modularity baseline, so this branch merges part 1 and its diff against main includes part 1 until that lands. Review only the commits after part 1.

What moved and why

Kernel files named only by Processes now count to Processes, by csv row (no file moves, no code change): the agent-run, flow e-mail, flow timer, flow trigger, form dependent, decision request, case item and task sequence events with their payload values, the lifecycle action plug-in types (LifecycleActionContext, LifecycleActionInterface, LifecycleActionProviderInterface, LifecycleActionInvoker, the lifecycle guard context and transition guard, SetFieldsAction, ContextLifecycleActionInterface, LegacyLifecycleActionInterface, BuiltinLifecycleActionsInterface), Service/Form/PublishedForm, FormDependent, the timer firing values and the Processes refusals (case, flow, form, task, BPMN, lifecycle, portal, bulk job). They run flows, tasks, cases and lifecycle transitions, which is Processes' work. Five Lifecycle/ files that fell under the directory row got a file row. Other apps name some of these classes; only the area changes, which they cannot see.

  • Processes: Event/AbstractDecisionRequestEvent.php, Event/AbstractTaskSequenceEvent.php, Event/AgentRunDispatch.php, Event/AgentRunInstruction.php, Event/AgentRunRequestedEvent.php, Event/CaseItemTransitionedEvent.php, Event/DecisionChangeRequestedEvent.php, Event/DecisionVisibilityRequestedEvent.php, Event/FlowEmailItem.php, Event/FlowEmailMessage.php, Event/FlowEmailOrigin.php, Event/FlowEmailSentEvent.php, Event/FlowTimerFiredEvent.php, Event/FormDestinationDependentsEvent.php, Event/RegisterFlowTriggersEvent.php, Exception/ActionParameterTypeException.php, Exception/BpmnImportRefused.php, Exception/BpmnSchemaInvalid.php, Exception/BulkJobRefusedException.php, Exception/CaseAccessDeniedException.php, Exception/CaseCascadeBoundException.php, Exception/CasePlanExistsException.php, Exception/CaseTransitionException.php, Exception/CaseValidationException.php, Exception/FlowRunExpired.php, Exception/FlowSignalRefused.php, Exception/FlowTimerStateException.php, Exception/FlowTimerValidationException.php, Exception/FormSubmitRefusedException.php, Exception/InvalidTransitionInputException.php, Exception/LifecycleProviderException.php, Exception/LifecycleSubjectNotFoundException.php, Exception/PortalPartyNotFoundException.php, Exception/PortalSubjectException.php, Exception/TaskCompleteViaAppException.php, Exception/TaskFormRefusedException.php, Exception/TaskSeparationOfDutiesException.php, Exception/TaskSubjectNotFoundException.php, Exception/TaskSubjectWriteRefusedException.php, Lifecycle/Action/SetFieldsAction.php, Lifecycle/BuiltinLifecycleActionsInterface.php, Lifecycle/ContextLifecycleActionInterface.php, Lifecycle/LegacyLifecycleActionInterface.php, Lifecycle/LifecycleActionContext.php, Lifecycle/LifecycleActionInterface.php, Lifecycle/LifecycleActionInvoker.php, Lifecycle/LifecycleActionProviderInterface.php, Lifecycle/LifecycleGuardContext.php, Lifecycle/LifecycleTransitionGuardInterface.php, Service/Flow/Timer/EscalationNotice.php, Service/Flow/Timer/TimerFiring.php, Service/Form/FormDependent.php, Service/Form/PublishedForm.php

Re-measured on main b85c154e

Exposed lines per area (part 1 → this PR)

Area Before After Difference
Kernel 7,382 6,597 -785
Core 57,351 57,351 +0
Notifications 1,760 1,760 +0
Search 1,344 1,344 +0
Compliance 14,300 14,300 +0
Files 1,263 1,263 +0
Integrations 17,733 17,733 +0
Processes 27,040 27,040 +0
Configuration 874 874 +0
Platform 61 61 +0
Total 129,108 128,323 -785

References against the order

38 before, 38 after. No newly exposed file, no new Kernel file.

Modularity baseline

Re-recorded with --write-baseline on top of part 1's: 48 entries of exposed_files and 53 of kernel_files gone, exposed_loc Kernel 7,382 → 6,597, kernel_loc 9,044 → 8,173, violation degree 0.0049 → 0.005 (inside the check's slack; area pairs shift, nothing points up). against_order unchanged.

What ran

  • php -l, phpcs, psalm: no PHP file changed (the diff is the csv, the two files generated from it and the modularity baseline), so nothing to lint.
  • phpstan on lib: lib/ is byte-identical to main b85c154e; vendor/bin/phpstan analyse --no-progress reports the same 37 errors main has, none new.
  • python3 scripts/component-patterns.py and deptrac_areas.py regenerated the two generated files; component-patterns.py --check passes (only the stale-row notices main already prints).
  • The modularity check --check: passed against main's baseline before re-recording (gone entries only, no newly exposed file, no new Kernel file, no new reference against the order); passes after --write-baseline.
  • The deptrac areas check --check: passed, 39 class pairs in violation as recorded (its "851 gone" notice is the same on main; the deptrac baseline is left to the coordinator).
  • vendor/bin/phpunit --no-coverage tests/Unit/Architecture (all of it, run in two halves): OK, 2,371 tests, 8,057 assertions.

Land after part 1.

Written with Claude Code (claude-opus-5-5)


Generated by Claude Code

…cesses

The task, flow, form, decision and agent-run events, the lifecycle
action plug-in types and the Processes refusals are named only by
Processes: their csv rows move from Kernel to Processes (kernel.md
K5-02, Appendix A "To Processes"). The five Lifecycle files that fell
under the Lifecycle directory row get a file row of their own.

TaskTerminalEvent stays in Kernel until Processes dispatches it itself
(K5-04).

Assisted-by: ClaudeCode:claude-opus-5-5
…ocesses' Kernel files to Processes

Assisted-by: ClaudeCode:claude-opus-5-5
@rubenvdlinde
rubenvdlinde requested a review from a team as a code owner November 21, 2026 16:07
@rubenvdlinde
rubenvdlinde merged commit 486930a into main Nov 21, 2026
0 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant