Repository navigation
refactor(architecture): count Kernel files only Processes uses to Processes (X95, part 2) - #10993
Merged
Merged
Conversation
…cesses The task, flow, form, decision and agent-run events, the lifecycle action plug-in types and the Processes refusals are named only by Processes: their csv rows move from Kernel to Processes (kernel.md K5-02, Appendix A "To Processes"). The five Lifecycle files that fell under the Lifecycle directory row get a file row of their own. TaskTerminalEvent stays in Kernel until Processes dispatches it itself (K5-04). Assisted-by: ClaudeCode:claude-opus-5-5
…ocesses' Kernel files to Processes Assisted-by: ClaudeCode:claude-opus-5-5
…#10993 Assisted-by: ClaudeCode:claude-opus-5-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Package X95 (K-rows), part 2 of 3: kernel.md K5-02, Appendix A "To Processes".
Stacked on part 1 (
cloud/mod-X95-core-rows): both parts edit the same rows file and the modularity baseline, so this branch merges part 1 and its diff against main includes part 1 until that lands. Review only the commits after part 1.What moved and why
Kernel files named only by Processes now count to Processes, by csv row (no file moves, no code change): the agent-run, flow e-mail, flow timer, flow trigger, form dependent, decision request, case item and task sequence events with their payload values, the lifecycle action plug-in types (
LifecycleActionContext,LifecycleActionInterface,LifecycleActionProviderInterface,LifecycleActionInvoker, the lifecycle guard context and transition guard,SetFieldsAction,ContextLifecycleActionInterface,LegacyLifecycleActionInterface,BuiltinLifecycleActionsInterface),Service/Form/PublishedForm,FormDependent, the timer firing values and the Processes refusals (case, flow, form, task, BPMN, lifecycle, portal, bulk job). They run flows, tasks, cases and lifecycle transitions, which is Processes' work. FiveLifecycle/files that fell under the directory row got a file row. Other apps name some of these classes; only the area changes, which they cannot see.Event/AbstractDecisionRequestEvent.php,Event/AbstractTaskSequenceEvent.php,Event/AgentRunDispatch.php,Event/AgentRunInstruction.php,Event/AgentRunRequestedEvent.php,Event/CaseItemTransitionedEvent.php,Event/DecisionChangeRequestedEvent.php,Event/DecisionVisibilityRequestedEvent.php,Event/FlowEmailItem.php,Event/FlowEmailMessage.php,Event/FlowEmailOrigin.php,Event/FlowEmailSentEvent.php,Event/FlowTimerFiredEvent.php,Event/FormDestinationDependentsEvent.php,Event/RegisterFlowTriggersEvent.php,Exception/ActionParameterTypeException.php,Exception/BpmnImportRefused.php,Exception/BpmnSchemaInvalid.php,Exception/BulkJobRefusedException.php,Exception/CaseAccessDeniedException.php,Exception/CaseCascadeBoundException.php,Exception/CasePlanExistsException.php,Exception/CaseTransitionException.php,Exception/CaseValidationException.php,Exception/FlowRunExpired.php,Exception/FlowSignalRefused.php,Exception/FlowTimerStateException.php,Exception/FlowTimerValidationException.php,Exception/FormSubmitRefusedException.php,Exception/InvalidTransitionInputException.php,Exception/LifecycleProviderException.php,Exception/LifecycleSubjectNotFoundException.php,Exception/PortalPartyNotFoundException.php,Exception/PortalSubjectException.php,Exception/TaskCompleteViaAppException.php,Exception/TaskFormRefusedException.php,Exception/TaskSeparationOfDutiesException.php,Exception/TaskSubjectNotFoundException.php,Exception/TaskSubjectWriteRefusedException.php,Lifecycle/Action/SetFieldsAction.php,Lifecycle/BuiltinLifecycleActionsInterface.php,Lifecycle/ContextLifecycleActionInterface.php,Lifecycle/LegacyLifecycleActionInterface.php,Lifecycle/LifecycleActionContext.php,Lifecycle/LifecycleActionInterface.php,Lifecycle/LifecycleActionInvoker.php,Lifecycle/LifecycleActionProviderInterface.php,Lifecycle/LifecycleGuardContext.php,Lifecycle/LifecycleTransitionGuardInterface.php,Service/Flow/Timer/EscalationNotice.php,Service/Flow/Timer/TimerFiring.php,Service/Form/FormDependent.php,Service/Form/PublishedForm.phpRe-measured on main
b85c154eBulkActionRegistrationEvent(X73),TaskSequenceCompletedEvent,TaskSequenceUndecidedEvent(refactor(architecture): the task sequence events count to Processes #10909) andTaskTransitionedEventcount to Processes already.TaskTerminalEventstays in Kernel: Core still names it, until Processes dispatches it itself (X96, K5-04).Exposed lines per area (part 1 → this PR)
References against the order
38 before, 38 after. No newly exposed file, no new Kernel file.
Modularity baseline
Re-recorded with
--write-baselineon top of part 1's: 48 entries ofexposed_filesand 53 ofkernel_filesgone,exposed_locKernel 7,382 → 6,597,kernel_loc9,044 → 8,173, violation degree 0.0049 → 0.005 (inside the check's slack; area pairs shift, nothing points up).against_orderunchanged.What ran
php -l, phpcs, psalm: no PHP file changed (the diff is the csv, the two files generated from it and the modularity baseline), so nothing to lint.lib:lib/is byte-identical to mainb85c154e;vendor/bin/phpstan analyse --no-progressreports the same 37 errors main has, none new.python3 scripts/component-patterns.pyanddeptrac_areas.pyregenerated the two generated files;component-patterns.py --checkpasses (only the stale-row notices main already prints).--check: passed against main's baseline before re-recording (gone entries only, no newly exposed file, no new Kernel file, no new reference against the order); passes after--write-baseline.--check: passed, 39 class pairs in violation as recorded (its "851 gone" notice is the same on main; the deptrac baseline is left to the coordinator).vendor/bin/phpunit --no-coverage tests/Unit/Architecture(all of it, run in two halves): OK, 2,371 tests, 8,057 assertions.Land after part 1.
Written with Claude Code (claude-opus-5-5)
Generated by Claude Code