Skip to content

test(e2e): write the GEMMA plate peers and previous-catalogue import specs - #2118

Merged
rubenvdlinde merged 1 commit into
developmentfrom
cloud/b-stackiq-e2e-peers-legacy
Nov 21, 2026
Merged

rubenvdlinde merged 1 commit into
developmentfrom
cloud/b-stackiq-e2e-peers-legacy

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

Writes the two Playwright spec files that open tasks name and that were missing. Both come from the changes' scenarios and have not been run.

  • tests/e2e/spec-coverage/gemma-plate-peers.spec.ts (gemma-plate-views-peers-and-definitions, task 4, REQ-GPL-002). It seeds an own municipality, three comparable ones and one outside the inhabitants band. The endpoint case checks GET /api/reference-component-coverage/peers: it returns the type and band, the peer applications appear, and no organisation is named. The table and side-panel cases are marked fixme, because the layer is not on development yet (it is in feat(stackiq): build gemma-plate-views-peers-and-definitions #1974).
  • tests/e2e/spec-coverage/legacy-catalogue-import.spec.ts (landscape-migrate-from-previous-catalogue, task 4, REQ-LCM-001 to 003). Every case is marked fixme until the profile, the endpoints, the dialog and the fixture exist. tasks.md has a note saying so.

No task is ticked: e2e tasks stay open until the specs run against a live instance.

Checks

  • Hydra diff check: eslint, floor and phpunit pass. The gates step reports gate 66 (openregister-dependency-shape) on lib/Lifecycle/ArchitectureDecisionReviewGuard.php and lib/Service/Registration/ServiceFactories.php. This PR does not touch either file, and development fails the same way.
  • npm run lint: the same 21 errors as development, none in these files.
  • composer check:strict could not run. composer install cannot finish in this container because GitHub answers 403 to the phpstan dist download (api.github.com/repos/phpstan/phpstan/zipball/...), and the lock has no source for that package. The PR changes no PHP, so the PHPUnit failure set is the same as development.

Generated by Claude Code

…specs

Two Playwright specs the open tasks name and the repository lacked, written
from the changes' scenarios and not run:

- spec-coverage/gemma-plate-peers.spec.ts (REQ-GPL-002): the peers endpoint
  counts only organisations of the same type and inhabitants band and names
  none; the table and side panel cases are fixme until the layer lands.
- spec-coverage/legacy-catalogue-import.spec.ts (REQ-LCM-001 to 003): every
  case fixme until the profile, endpoints, dialog and fixture exist.

Assisted-by: ClaudeCode:claude-opus-5-5
@rubenvdlinde
rubenvdlinde merged commit 98773d6 into development Nov 21, 2026
5 of 7 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/stackiq @ c98186a

Check PHP Vue Security License Tests
lint ✅
phpcs ✅
phpmd ❌
psalm ❌
phpstan ✅
phpmetrics ✅
eslint ❌
stylelint ✅
build ✅
check-manifest ✅
check-vue-demi ✅
test-l10n ✅
format ❌
check-schema-l10n ❌
check-l10n-js ✅
composer ❌ ✅ 150/150
npm ✅ ✅ 811/811
app:check-code ⏭️
info.xml ✅
REUSE ❌
lockfile sync ✅
PHPUnit ❌
Newman ⏭️
Playwright ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development.
Hydra gates ❌

Quality workflow — 2026-11-21 20:26 UTC

Download the full PDF report from the workflow artifacts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant