Repository navigation
test(e2e): write the GEMMA plate peers and previous-catalogue import specs - #2118
Merged
Merged
Conversation
…specs Two Playwright specs the open tasks name and the repository lacked, written from the changes' scenarios and not run: - spec-coverage/gemma-plate-peers.spec.ts (REQ-GPL-002): the peers endpoint counts only organisations of the same type and inhabitants band and names none; the table and side panel cases are fixme until the layer lands. - spec-coverage/legacy-catalogue-import.spec.ts (REQ-LCM-001 to 003): every case fixme until the profile, endpoints, dialog and fixture exist. Assisted-by: ClaudeCode:claude-opus-5-5
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn and
remko48
as code owners
November 21, 2026 19:27
Contributor
Quality Report — ConductionNL/stackiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ❌ | ||||
| psalm | ❌ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| check-vue-demi | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ❌ | ||||
| check-schema-l10n | ❌ | ||||
| check-l10n-js | ✅ | ||||
| composer | ❌ | ✅ 150/150 | |||
| npm | ✅ | ✅ 811/811 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-11-21 20:26 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Writes the two Playwright spec files that open tasks name and that were missing. Both come from the changes' scenarios and have not been run.
tests/e2e/spec-coverage/gemma-plate-peers.spec.ts(gemma-plate-views-peers-and-definitions, task 4, REQ-GPL-002). It seeds an own municipality, three comparable ones and one outside the inhabitants band. The endpoint case checksGET /api/reference-component-coverage/peers: it returns the type and band, the peer applications appear, and no organisation is named. The table and side-panel cases are marked fixme, because the layer is not on development yet (it is in feat(stackiq): build gemma-plate-views-peers-and-definitions #1974).tests/e2e/spec-coverage/legacy-catalogue-import.spec.ts(landscape-migrate-from-previous-catalogue, task 4, REQ-LCM-001 to 003). Every case is marked fixme until the profile, the endpoints, the dialog and the fixture exist. tasks.md has a note saying so.No task is ticked: e2e tasks stay open until the specs run against a live instance.
Checks
lib/Lifecycle/ArchitectureDecisionReviewGuard.phpandlib/Service/Registration/ServiceFactories.php. This PR does not touch either file, and development fails the same way.npm run lint: the same 21 errors as development, none in these files.composer check:strictcould not run.composer installcannot finish in this container because GitHub answers 403 to the phpstan dist download (api.github.com/repos/phpstan/phpstan/zipball/...), and the lock has no source for that package. The PR changes no PHP, so the PHPUnit failure set is the same as development.Generated by Claude Code