Repository navigation
chore(openspec): archive bound-unbounded-searchobjects-scans with its spec synced - #2120
Merged
Merged
Conversation
… spec synced Task 5.3 is met: Psalm reports no finding on a line this change wrote, and PHPCS, PHPMD and PHPStan were already clean on the touched files. The one requirement goes to openspec/specs/query-performance, and the @SPEC tags point at the synced spec. Assisted-by: ClaudeCode:claude-opus-5-5
TechnologyComponentEolStamper::components() was the one call site of SearchBounds::bounded() without the reasoned PHPMD suppression the other call sites carry, so PHPMD still reported it. Assisted-by: ClaudeCode:claude-opus-5-5
rubenvdlinde
requested review from
Rem-Dam,
WilcoLouwerse,
bbrands02 and
rjzondervan
as code owners
November 21, 2026 21:22
Contributor
Quality Report — ConductionNL/stackiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ❌ | ||||
| psalm | ❌ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| check-vue-demi | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ❌ | ||||
| check-schema-l10n | ❌ | ||||
| check-l10n-js | ✅ | ||||
| composer | ❌ | ✅ 150/150 | |||
| npm | ✅ | ✅ 811/811 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-11-21 22:26 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
composer check:strictviolations) ofbound-unbounded-searchobjects-scansand archives the change.SearchBounds.php.StaticAccessonSearchBounds::bounded(), inTechnologyComponentEolStamper::components(). That method now carries the same reasoned suppression as the other call sites.openspec/specs/query-performance/spec.md. The@spectags point at the synced spec.Verification
amef_version, gate 66 on container lookups inArchitectureDecisionReviewGuardandServiceFactories) are in files this PR does not touch. The 29 phpcs findings inQueryLimitBoundingTest.phpare inherited.composer check:strict:SearchBounds.test:all: skipped, because it needs a Nextcloud tree.npm run lint: 21 errors, all in files from development. This PR changes no JS or Vue.Generated by Claude Code