Skip to content

chore(openspec): archive bound-unbounded-searchobjects-scans with its spec synced - #2120

Merged
rubenvdlinde merged 2 commits into
developmentfrom
cloud/b-stackiq-bounded-scans-archive
Nov 21, 2026
Merged

rubenvdlinde merged 2 commits into
developmentfrom
cloud/b-stackiq-bounded-scans-archive

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

What

  • Ticks the last task (5.3, no new composer check:strict violations) of bound-unbounded-searchobjects-scans and archives the change.
  • Psalm 7.6 ran on development: none of its 736 findings sits on a line this change's commits wrote, and none is in SearchBounds.php.
  • PHPMD still reported one StaticAccess on SearchBounds::bounded(), in TechnologyComponentEolStamper::components(). That method now carries the same reasoned suppression as the other call sites.
  • The one requirement is synced to openspec/specs/query-performance/spec.md. The @spec tags point at the synced spec.

Verification

  • Hydra diff check: no new findings. The two gate failures it prints (gate 59 on amef_version, gate 66 on container lookups in ArchitectureDecisionReviewGuard and ServiceFactories) are in files this PR does not touch. The 29 phpcs findings in QueryLimitBoundingTest.php are inherited.
  • composer check:strict:
    • PHPStan: no errors.
    • PHPMD: reports nothing on SearchBounds.
    • test:all: skipped, because it needs a Nextcloud tree.
  • PHPUnit unit suite: 4,413 tests. The same 3 tests fail as on development alone.
  • npm run lint: 21 errors, all in files from development. This PR changes no JS or Vue.

Generated by Claude Code

… spec synced

Task 5.3 is met: Psalm reports no finding on a line this change wrote,
and PHPCS, PHPMD and PHPStan were already clean on the touched files.
The one requirement goes to openspec/specs/query-performance, and the
@SPEC tags point at the synced spec.

Assisted-by: ClaudeCode:claude-opus-5-5
TechnologyComponentEolStamper::components() was the one call site of
SearchBounds::bounded() without the reasoned PHPMD suppression the other
call sites carry, so PHPMD still reported it.

Assisted-by: ClaudeCode:claude-opus-5-5
@rubenvdlinde
rubenvdlinde merged commit ffb7bde into development Nov 21, 2026
5 of 7 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/stackiq @ da79f6a

Check PHP Vue Security License Tests
lint ✅
phpcs ✅
phpmd ❌
psalm ❌
phpstan ✅
phpmetrics ✅
eslint ❌
stylelint ✅
build ✅
check-manifest ✅
check-vue-demi ✅
test-l10n ✅
format ❌
check-schema-l10n ❌
check-l10n-js ✅
composer ❌ ✅ 150/150
npm ✅ ✅ 811/811
app:check-code ⏭️
info.xml ✅
REUSE ❌
lockfile sync ✅
PHPUnit ❌
Newman ⏭️
Playwright ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development.
Hydra gates ❌

Quality workflow — 2026-11-21 22:26 UTC

Download the full PDF report from the workflow artifacts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant