Repository navigation
refactor(discovery): merge provider results in a DiscoveryMerge and pass the search filter as one object - #569
Merged
Conversation
Assisted-by: ClaudeCode:claude-opus-5-5
…ass the search filter as one object DiscoveryAggregator::search() takes the provider ids and the installed-only flag as one DiscoveryFilter, and a per-search DiscoveryMerge groups the hits, prefers App Store metadata, collects provider errors and sorts the results. Assisted-by: ClaudeCode:claude-opus-5-5
…pp Store hits Assisted-by: ClaudeCode:claude-opus-5-5
Assisted-by: ClaudeCode:claude-opus-5-5
Contributor
Quality Report — ConductionNL/versioniq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| composer | ✅ | ✅ 32/32 | |||
| npm | ❌ | ✅ 302/302 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ✅ 898/898 · 7 skipped (8 legs) | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ✅ |
Quality workflow — 2026-11-02 22:44 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DiscoveryAggregator::search()was the largest PHP unit in versioniq (62 LOC, McCabe 14, 3 parameters). It now takes the provider ids and the installed-only flag as oneDiscoveryFilter, turns a throwing provider into a failed result inrunProvider(), and hands the merging to a per-searchDiscoveryMerge, which groups hits by app id, prefers App Store summary and icon, collects provider errors and sorts installed apps first, then by name. Its one caller,ApiController::discover, passes the filter; the request parameters and the response are unchanged.SIG numbers (gate 122, five-star profile, PHP, against development 3e6e4b8)
No PHP unit is above 60 LOC any more. Every touched or new unit is within the 5-star unit bounds (at most 12 LOC, McCabe 5, 2 params). versioniq stays 36/44 at 4-star. Gate 122 ratchet: 0 findings. Gate 123 (floor from #564): 36 held. Together with #567 and #568 this keeps the params >=3 share below development's while those two remove duplication.
Verification
DiscoveryAggregatorGoldenTest: 23 cases (every provider-id filter with and without installed-only, providers disabled, throwing, returning errors or no hits, App Store duplicates, name ties), comparing the payload and every provider and app manager call. Recorded on the old code; plain re-run green on old and new.--fail-on-risky: OK (792 tests).composer check:strict: lint and psalm clean; php-cs-fixer flags only the inheritedRemoveRetiredCronJobspair. Hydra gates--scope-to-diff --base origin/development: exit 0.AI assisted (Claude Code); reviewed against the golden before opening.