Skip to content

CXH-2461: enforce unique role_name in Postgres test fixture #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
al-conductorone merged 1 commit into from
Sep 17, 2026
Merged

CXH-2461: enforce unique role_name in Postgres test fixture #154

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/postgres-init.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ UPDATE users SET manager_id = (SELECT id FROM users WHERE username = 'robert.tab
-- Create roles table
CREATE TABLE roles (
id SERIAL PRIMARY KEY,
role_name VARCHAR(100) NOT NULL
role_name VARCHAR(100) NOT NULL UNIQUE

@github-actions github-actions Bot Sep 16, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Suggestion: This matches what examples/postgres-test.yml already assumes (role resource id: ".role_name"), and the seeded values admin/user/reader are already distinct, so the constraint is safe. For parity, test/mysql-init.sql:66 has the same roles.role_name column without UNIQUE while examples/mysql-test.yml:310 also derives the role resource ID from .role_name — worth adding the same constraint there (test/sqlserver-init.sql:23 already has it).

);

-- Insert sample roles
Expand Down
Loading