Skip to content

Admit all four binary targets instead of queueing the fourth #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Bencheng21 wants to merge 2 commits into from
Closed

Admit all four binary targets instead of queueing the fourth #125

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
106450e
Admit all four binary targets instead of queueing the fourth
Bencheng21 Sep 23, 2026
82350fe
Pin the binaries build semaphore to -p 3
Bencheng21 Sep 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,6 +313,16 @@ jobs:
binaries_checksums: ${{ steps.output-checksums.outputs.checksums }}
released_at: ${{ steps.release-meta.outputs.released_at }}
steps:
# Records the core count so a run can be read correctly: GitHub bills the
# standard macOS tier as "3-core or 4-core", and a 4-core runner would admit
# all four targets even without -p, masking the flag's effect.
- name: Report runner hardware
shell: bash
run: |
echo "ncpu=$(sysctl -n hw.ncpu) logical=$(sysctl -n hw.logicalcpu) physical=$(sysctl -n hw.physicalcpu)"
echo "cpu=$(sysctl -n machdep.cpu.brand_string 2>/dev/null || echo unknown)"
echo "mem_bytes=$(sysctl -n hw.memsize)"

- name: Checkout caller repo
uses: actions/checkout@v5
with:
Expand Down Expand Up @@ -417,12 +427,17 @@ jobs:
role-to-assume: arn:aws:iam::025044153841:role/${{ steps.role-names.outputs.gha_artifacts_role_name }}
aws-region: us-west-2

# -p pins GoReleaser's build semaphore, which otherwise defaults to
# runtime.GOMAXPROCS(0) (cmd/release.go). The standard macOS fleet is mixed
# (GitHub bills it as "3-core or 4-core"), so the number of the four targets
# that run concurrently varies by whichever machine a release lands on.
# Pinning it makes the release reproducible instead of a hardware lottery.
- name: Run GoReleaser
uses: goreleaser/goreleaser-action@v6
with:
workdir: _caller
version: "~> v2.13"
args: release --clean --config ../_workflows/_generated/.goreleaser.binaries.yaml
args: release --clean -p 3 --config ../_workflows/_generated/.goreleaser.binaries.yaml
env:
GITHUB_TOKEN: ${{ secrets.RELENG_GITHUB_TOKEN }}
GORELEASER_CURRENT_TAG: ${{ inputs.tag }}
Expand Down