Repository navigation
image lifecycle: the test CDN serves only what its indexes list - #15
Merged
Merged
Conversation
The fake update CDN took a release file's name from the request and joined it to a path on disk, behind a regex and a slot check. CodeQL (go/path-injection) cannot see a regex as a sanitiser, and a name a release did not publish was served when it matched the pattern. Each index's lines now make the map of what exists, name to path, at construction; a request only looks a name up, and anything the indexes do not list, a path out of the slot included, is 404. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes CodeQL alert #1 (
go/path-injection,cmd/image/lifecycle.go).The fake update CDN
test:lifecycleruns took a release file's name from the request and joined it to a path on disk, behind a regex and a slot check. CodeQL cannot see a regex as a sanitiser, and a well-formed name no release published was served when it matched the pattern.Each index's lines now make the map of what exists, name to path, at construction; a request only looks a name up. Anything the indexes do not list is 404: a version no release has, a file in another release's slot, a release directory's other files, a path out of the slot.
TestUpdateCDNcovers the four.task checkpasses.🤖 Generated with Claude Code