Repository navigation
Fix drag and drop functionality in editor - #4003
Merged
georgweiss merged 1 commit intoNov 2, 2026
Merged
Conversation
Bug was introduced when changing the background of the scroll pane to stop flickering scroll bars. The fix brings back the sizing listener to set the min width/ height of the widget_pane so that the background is correctly drawn to that size. Drag and drop also did not work if you changed the model width/height to a value larger than the current viewport and tried to drag on to the new area. I have also fixed that by updating the min width/height when the model size is changed.
|
Contributor
Author
|
@georgweiss - see fix for drag and drop bug |
georgweiss
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug was introduced when changing the background of the scroll pane to stop flickering scroll bars- see #3972 (comment).
It was a bit of a weird one. If you had a blank/new screen then you could not drag and drop. However as soon there was a widget in the screen, you could then drag and drop within the region 0,0 and the widget. So the issue came down to the fact that the widget_pane was not being drawn out to the size of the viewport/model size.
The fix brings back the sizing listener to set the min width/ height of the widget_pane so that the background is correctly drawn to that size. Note that we only want to do this for the editor. The runtime display functions correctly and we do not want to set it's size in this listener as otherwise we will return back to flickering scroll bars.
The drag and drop also did not work prior to the above changes in the case that you changed the model width/height to a value larger than the current viewport and tried to drag on to the new area. I have also fixed that by updating the min width/height when the model size is changed.
Checklist
Testing:
Documentation: