Repository navigation
Conversation
LordIdra
force-pushed
the
undialogify-alarm-config-editing
branch
from
November 3, 2026 16:35
5b2f9ea to
64670a2
Compare
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Part of #3995
Depends on #3987 - has changes from 3987 mixed into it as I can't create a branch on this repo to base the changes off of, so I have marked this as a draft
Next PR will likely be improvements to the guidance/displays/commands/actions menus, building on this one
I am holding off documenting any of this right now as subsequent PRs will change alarm configuration further
Also found some bugs while doing this which I fixed. Just to flag, I have realised during this that the 'automated actions' dialog box buttons are pretty much non-functional as only the 'add' button handler has been overridden - this is an issue in 6.0.0 too, I have not bothered to fix this here as I plan to overhaul those dialog boxes next (or embed them into the properties panel).
Demo
2026-11-03.16-23-21.mp4
2026-11-03.16-25-20.mp4
Changes
AlarmClientNode#createDetachedCopyAlarmTreeItem#configsEqualDateTimePicker#dateTimePropertyitemUpdatedbeing called for tombstone messagesAlarmClientLeaf#setEnabledDatethrowing NPE if provided with nullJsonModelReader#updateAlarmLeafConfigwhich meant that the function would sometimes not count a node's enabled state as being changed even though it has been changedSome things I'm not sure on
AlarmTreeItem#configEquals? Sealed interface would be nice but wary of creating new interfaces for a small thing like thisChecklist
Testing:
Documentation: