Skip to content

fix(agent-endpoint): correctly handle bracketed IPv6 hosts with port in allowed list #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidmckayv merged 1 commit into from
Sep 3, 2026
+16 −2
Merged

fix(agent-endpoint): correctly handle bracketed IPv6 hosts with port in allowed list #330

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion server/src/agents/endpoint.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ function namedAsAllowed(
return false;
}
const hostname = url.hostname.toLowerCase().replace(/^\[|\]$/g, "");
const host = url.host.toLowerCase().replace(/^\[/, "").replace(/\]/, "");
const host = url.port ? `${hostname}:${url.port}` : hostname;
return allowedHosts.has(host) || allowedHosts.has(hostname);
}

Expand Down
16 changes: 15 additions & 1 deletion server/src/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -634,11 +634,25 @@ function agentEndpointAllowedHosts(
`AGENT_ENDPOINT_ALLOWED_HOSTS entry "${entry}" must name one host. Patterns are not accepted: list each address instead.`,
);
}
hosts.add(host.replace(/^\[/, "").replace(/\]$/, ""));
hosts.add(normalizeAllowedHost(host));
}
return hosts;
}

function normalizeAllowedHost(host: string): string {
// IPv6 is bracketed as [host] or [host]:port. Strip the brackets and keep the port.
if (host.startsWith("[")) {
const close = host.indexOf("]");
if (close === -1) return host.replace(/^\[/, "").replace(/\]$/, "");
const ipv6 = host.slice(1, close).toLowerCase();
const rest = host.slice(close + 1);
if (!rest) return ipv6;
if (rest.startsWith(":")) return `${ipv6}${rest.toLowerCase()}`;
return `${ipv6}${rest.toLowerCase()}`;
}
return host;
}

function privateHostsAllowed(environment: Environment): boolean {
if (optional(environment, "AGENT_COMPUTER_ALLOW_PRIVATE_HOSTS") !== "true") {
return false;
Expand Down