Repository navigation
Leave opening a remote Bot to everybody to an administrator - #893
Closed
prysthedev wants to merge 1 commit into
Closed
prysthedev wants to merge 1 commit into
prysthedev wants to merge 1 commit into
Conversation
Any signed-in person could register a Bot at an address of their own and mark it public. A public Bot is offered to every person in the deployment, and a remote one is sent each of their conversations along with the run assertion it calls tools with, so the person running that server saw what everybody said to it and could act as each of them within the Bot's grants. Creating a public Bot with its own endpoint, or making a remote Bot public, is now refused for anyone but an admin, with a message that points at keeping it private and sharing it with named people. Bots with no endpoint, or on the deployment's own managed Bot, are unaffected, and admins can still publish remote Bots.
prysthedev
requested review from
MikeRyanDev,
davidmckayv,
dustywusty,
guidovizoso,
mxmzb,
samjulien and
tylerslaton
as code owners
October 29, 2026 23:40
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Any signed-in person could register a Bot at an address of their own and mark it public. A public Bot is offered to every person in the deployment, and a remote one is sent each of their conversations along with the run assertion it calls tools with, so the person running that server saw what everybody said to it and could act as each of them within the Bot's grants.
Creating a public Bot with its own endpoint, or making a remote Bot public, is now refused for anyone but an admin, with a message that points at keeping it private and sharing it with named people. Bots with no endpoint, or on the deployment's own managed Bot, are unaffected, and admins can still publish remote Bots.
What this changes
Where it runs
OpenBot is deployed as several server processes behind a load balancer, serving a whole company.
Consecutive requests from the same person reach different processes, and the process that answered a
WebSocket upgrade is rarely the one that answers the next call on that conversation.
State that outlives a single request therefore has to be shared, or the change works on one machine
and stops working the moment there are two, without saying so. That failure is worse than not
shipping the feature: it passes review, passes CI, passes a local demo, and only surfaces as a Bot
that forgets, a question nobody can answer, or a boundary that never fires.
Answer these even when the answer is "none":
MaporSetheld in a module ora factory closure does not count as somewhere.
conditional update, or an advisory lock are answers. A check-then-write is not.
and what a hundred copies of it do.
Postgres is already there and is the default answer to all of the above: a table, a unique index, a
conditional update,
LISTEN/NOTIFYfor fan-out.Boundary and audit
Changelog
CHANGELOG.mdunderUnreleased, or a sentence on why a deployment behaves nodifferently afterwards.
Proof