Skip to content

Wait for the lines logged after a request's removal before asserting them #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arifBurakDemiray merged 1 commit into from
Oct 22, 2026
Merged

Wait for the lines logged after a request's removal before asserting them #322

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sdk-java/src/test/java/ly/count/sdk/java/internal/ModuleConfigurationNetworkTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ public void backoff_neverAfterARequestOlderThanTheRequestAge_norWhileTheServerTu

Assert.assertTrue("the old requests never drained, logs: " + logs, waitFor(() -> queueServer.received.size() == 2 && queuedRequestCount() == 0));
Assert.assertEquals(Arrays.asList("old_1", "old_2"), receivedParams("marker"));
Assert.assertEquals(2, logsContaining("but the request is older than [1] hours, " + NOT_BACKING_OFF));
awaitLogs("but the request is older than [1] hours, " + NOT_BACKING_OFF, 2);
Assert.assertEquals(0, logsContaining(BACKOFF_STARTED));
Countly.instance().halt();

Expand Down Expand Up @@ -396,7 +396,7 @@ public void requestDropAge_settlesTheJourneyTriggerOfADroppedRequest_andALaterTr
push(new ServerConfigBuilder().networking(true).journeyTriggerEvents(names("purchase")).dropOldRequestTime(1));
Assert.assertTrue("the aged request was never dropped, logs: " + logs, waitNudging(() -> queuedRequestCount() == 0));
Assert.assertEquals(1, logsContaining(DROPPED_UNSENT));
Assert.assertEquals(1, logsContaining("carrying a journey trigger failed with code [" + Transport.NO_RESPONSE_CODE + "], the content zone is not refreshed"));
awaitLogs("carrying a journey trigger failed with code [" + Transport.NO_RESPONSE_CODE + "], the content zone is not refreshed", 1);
Assert.assertTrue(pending.isEmpty());
Assert.assertTrue(queueServer.received.isEmpty());
assertZoneIsInactive(0);
Expand Down