Repository navigation
Updated Cypress to 14.5.4 and fixed end-to-end tests - #1833
Merged
Merged
Conversation
- Migrated the legacy cypress.json config (unsupported since Cypress 10) to cypress.config.js - Updated outdated test IDs (course codes now have session suffixes, e.g. csc209h1) and graph structure - Looked up hybrid edge IDs at runtime, since they are database-generated - Added a support file that hides the disclaimer popup, which blocked interactions - Added missing cy.visit for test isolation, and aligned overridden-prereq hover assertions with Node.test.js - Added cypress:run/cypress:open scripts and README instructions Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Coverage Report for CI Build 43622453243Coverage decreased (-0.02%) to 61.596%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats💛 - Coveralls |
- Run Cypress in the CI build job against a server with the graphs database - Cache the Cypress binary and upload screenshots/server log on failure - Stub /course in the Info Box test with a fixture, since course info otherwise requires scraping the Arts & Science Calendar Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Updates Cypress to the latest 14.x release (14.5.4) and gets the end-to-end tests running again. Nobody had been running them, and they had fallen out of date with the app.
Cypress config
cypress.jsontocypress.config.jscypress/support/e2e.js, which hides the disclaimer popup before each page load. The popup covered part of the graph and caused "element is covered" failures./cypress/supportfrom.gitignore, added theCypressglobal to the ESLint config, and gitignoredcypress/screenshotsandcypress/videos.Test fixes
csc209→csc209h1), and some bool and hybrid nodes have changed.h3586->csc456h1), soedge_spec.jsnow looks up the hybrid's ID at runtime. Its hover tests now usecsc209h1→h(csc209h1)→csc456h1, since the hybrid they used before (h62→csc343) no longer exists.cy.visitto theCourse Nodeblock. These tests had relied on state left over from earlier tests.node_spec.jswithNode.test.js: hovering a child of an overridden course does not mark that course's unmet prerequisites as missing./coursewith a fixture (cypress/fixtures/csc108-course-info.json).CI
buildjob now runs the end-to-end tests. On failure, it uploads screenshots and the server log as acypress-failuresartifact. This adds about 45 seconds to CI.Docs
pnpm run cypress:runandpnpm run cypress:openscripts, plus a README section on running the end-to-end tests.Type of Change
Checklist
Before opening your pull request:
After opening your pull request:
Questions and Comments
🤖 Generated with Claude Code