Repository navigation
Conversation
There was a problem hiding this comment.
Thanks @Mehrn0ush for picking this up! I'm not convinced that a free-text role is the right solution, mainly because it's hard to define precisely what a role is.
- Most of the example roles (encryption, mac, signature, key-exchange) are cryptographic functions, which the referenced asset already states via
keyUsagefor keys orcryptoFunctionsfor algorithms. Both use thecryptographicFunctionenum, which I think is better than an open string, since it keeps CBOMs comparable. - I also see a role less as a property of the asset itself, and more as how another component uses it, e.g. an application that signs code with a key. For that, the 2.0 behaviors (e.g. security:cryptography:signsCode) seem a better fit. What might be missing today is a way to link a behavior to the key or algorithm used for it. Longer term, labelled dependencies could cover this, and the blueprint relationships already have typed edges we could build on.
Maybe blueprints already cover the last point, would be a good discussion point for this week's meeting.
94ba1e3 to
ab2db7b
Compare
Signed-off-by: Mehrn0ush <mehrnoush.vaseghi@gmail.com>
ab2db7b to
fe51305
Compare
|
Thanks @bhess. You are right. free-text What remains is a documentation fix to
|
bhess
left a comment
There was a problem hiding this comment.
LGTM, but I'd recommend to rename the title of the PR to reflect the updated scope.
| "description": "Specifies the mechanism by which the cryptographic asset is secured by.", | ||
| "description": "The kind of referenced cryptographic asset, such as an algorithm, certificate, public key, or private key.", | ||
| "examples": [ | ||
| "publicKey", |
There was a problem hiding this comment.
just noticed, the correct spelling in 2.0 is public-key and private-key, respectively.
…t type examples Signed-off-by: Mehrn0ush <mehrnoush.vaseghi@gmail.com>
Signed-off-by: Mehrn0ush <mehrnoush.vaseghi@gmail.com>
|
Fixed, Thanks @bhess. While checking, I found the same old spelling in existing 2.0 test fixtures: four related-asset entries used
|
The issue asked for a role on related assets. Basil pointed out that the asset already states its functions, and with the TLS and SSH properties the positions are covered too. So I've updated this PR to a small documentation fix: the type description there was a copy of the securedBy text. Nothing else is in it now.
Also updates four existing fixture entries from publicKey to public-key.
Thanks @bhess