-
-
Notifications
You must be signed in to change notification settings - Fork 92
[2.0] enforce refType/refLinkType non-conflicting with BOM-Link
#997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jkowalleck
wants to merge
11
commits into
2.0-dev
Choose a base branch
from
2.0-dev-refType-nonconflicting-bom-link
base: 2.0-dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
2c43df6
fix: prevent refType/refLinkType from being a Bom-Link
jkowalleck 97eec28
feat: common `elementLink`
jkowalleck 85c554d
refactor: use `elementLink`
jkowalleck 4cdefa6
fix: use `elementLink` according to description
jkowalleck 72384fd
docs
jkowalleck 17bc865
refactor
jkowalleck 34f1df7
fix: linked elemenets
jkowalleck 1606d88
fix: linked elemenets
jkowalleck 674b6a6
Merge branch '2.0-dev' into 2.0-dev-refType-nonconflicting-bom-link
jkowalleck 94942ee
Merge branch '2.0-dev' into 2.0-dev-refType-nonconflicting-bom-link
jkowalleck f18b11f
Update schema/2.0/model/cyclonedx-common-2.0.schema.json
jkowalleck File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -492,7 +492,7 @@ | |
| "title": "Address" | ||
| }, | ||
| "affiliation": { | ||
| "$ref": "cyclonedx-common-2.0.schema.json#/$defs/refLinkType", | ||
| "$ref": "cyclonedx-common-2.0.schema.json#/$defs/elementLink", | ||
| "title": "Affiliation", | ||
| "description": "Reference using bom-link or bom-ref to an organization party with which the person is affiliated." | ||
| } | ||
|
|
@@ -836,7 +836,7 @@ | |
| "title": "Expiration Date" | ||
| }, | ||
| "issuer": { | ||
| "$ref": "cyclonedx-common-2.0.schema.json#/$defs/refLinkType", | ||
| "$ref": "cyclonedx-common-2.0.schema.json#/$defs/elementLink", | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. description sayed - bom-link or ref to an element - so fixed the |
||
| "title": "Issuer", | ||
| "description": "Reference using bom-link or bom-ref to the party that issued the identifier." | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| { | ||
| "$schema": "http://cyclonedx.org/schema/bom-1.7.schema.json", | ||
| "bomFormat": "CycloneDX", | ||
| "specVersion": "1.7", | ||
| "serialNumber": "urn:uuid:3e9eb9b0-9577-4116-ac17-fad73a27b572", | ||
| "version": 1, | ||
| "components": [ | ||
| { | ||
| "type": "library", | ||
| "name": "example", | ||
| "description": "`bom-ref` should not start with 'urn:uuid:' - but it does, what is quite valid", | ||
| "bom-ref": "urn:uuid:313ec7e9-a6bb-4274-8749-e6fa8559afab" | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| { | ||
| "$schema": "https://cyclonedx.org/schema/2.0/cyclonedx-2.0.schema.json", | ||
| "specFormat": "CycloneDX", | ||
| "specVersion": "2.0", | ||
| "serialNumber": "urn:uuid:3e9eb9b0-9577-4116-ac17-fad73a27b572", | ||
| "version": "1", | ||
| "components": [ | ||
| { | ||
| "type": "library", | ||
| "name": "example", | ||
| "description": "`bom-ref` must not start with 'urn:uuid:'", | ||
| "bom-ref": "urn:uuid:313ec7e9-a6bb-4274-8749-e6fa8559afab" | ||
| } | ||
| ] | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description sayed - bom-link or ref to an element - so fixed the
$ref