[8.0] Add wait timeout when connecting to stomp - #8057
Merged
Conversation
DIRACGridBot
added
the
alsoTargeting:integration
chaen
reviewed
Mar 27, 2025
| self.connection.connect(username=user, passcode=password, wait=True) | ||
|
|
||
| # Connect to the broker with a timeout of 30 seconds | ||
| self.connection.connect(username=user, passcode=password, wait=False) |
Contributor
There was a problem hiding this comment.
But this is exactly what wait = True does
Member
Author
There was a problem hiding this comment.
It isn't as wait=True blocks forever and doesn't have a timeout.
Contributor
There was a problem hiding this comment.
From what I understand @chrisburr is right here:
chrisburr
force-pushed
the
stomp-connect-timeout
branch
2 times, most recently
from
May 20, 2025 10:15
29b8993 to
1c36a20
Compare
aldbr
previously requested changes
Apr 14, 2026
aldbr
left a comment
aldbr
left a comment
Contributor
There was a problem hiding this comment.
What's the status of this PR? Shall we try to finish it?
| self.connection.connect(username=user, passcode=password, wait=True) | ||
|
|
||
| # Connect to the broker with a timeout of 30 seconds | ||
| self.connection.connect(username=user, passcode=password, wait=False) |
Contributor
There was a problem hiding this comment.
From what I understand @chrisburr is right here:
|
|
||
| # Connect to the broker with a timeout of 30 seconds | ||
| self.connection.connect(username=user, passcode=password, wait=False) | ||
| self.transport.wait_for_connection(30) # pylint: disable=no-member |
Contributor
There was a problem hiding this comment.
There is no self.transport, IIUC what you want is self.connection.transport no? 😅
Contributor
|
Ping |
chrisburr
force-pushed
the
stomp-connect-timeout
branch
from
May 21, 2026 09:23
1c36a20 to
f081226
Compare
chaen
force-pushed
the
stomp-connect-timeout
branch
from
July 28, 2026 08:07
f081226 to
c245574
Compare
chaen
approved these changes
Jul 28, 2026
DIRACGridBot
added
the
sweep:done
DIRACGridBot
pushed a commit
to DIRACGridBot/DIRAC
that referenced
this pull request
Jul 28, 2026
|
Sweep summary Sweep ran in https://github.com/DIRACGrid/DIRAC/actions/runs/30346648092 Successful:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
*Core
FIX: Add wait timeout when connecting to stomp
ENDRELEASENOTES