Skip to content

Removed unused ListableModule - #6068

Open
alexandrevryghem wants to merge 1 commit into
DSpace:mainfrom
alexandrevryghem:removed-unused-listable-module
Open

Removed unused ListableModule#6068
alexandrevryghem wants to merge 1 commit into
DSpace:mainfrom
alexandrevryghem:removed-unused-listable-module

Conversation

@alexandrevryghem

@alexandrevryghem alexandrevryghem commented Aug 4, 2026

Copy link
Copy Markdown
Member

References

Description

In #4528 the dynamic decorator logic was restored. That PR removed all the usages of the ListableModule, but it looks like that file got accidentally restored (propably caused by the merge of #4446). This PR simply removes this module again & the lazy-listable-components.ts files.

When this is merged we will also have to update the migration docs to remove the "lazy-listable" references

Instructions for Reviewers

List of changes in this PR:

  • Deleted the ListableModule & all the lazy-listable-components.ts files in the themes

Guidance for how to test and review this PR:

  • Since this is unused code this shouldn't break anything but you can test that the listable objects like the item pages & the search results still work

Checklist

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR follows all coding best practices based on the Code Conventions Guide
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@alexandrevryghem alexandrevryghem self-assigned this Aug 4, 2026
@alexandrevryghem alexandrevryghem moved this to 🙋 Needs Reviewers Assigned in DSpace 11.0 Release Aug 4, 2026
@alexandrevryghem alexandrevryghem added this to the 11.0 milestone Aug 4, 2026
@tdonohue
tdonohue self-requested a review August 4, 2026 22:08
@tdonohue tdonohue added the 1 APPROVAL pull request only requires a single approval to merge label Aug 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge code task themes

Projects

Status: 🙋 Needs Reviewers Assigned

Development

Successfully merging this pull request may close these issues.

2 participants