Skip to content

[Port dspace-9_x] browse pages should not ignore sort config from back end - #6069

Merged
tdonohue merged 1 commit into
DSpace:dspace-9_xfrom
jsutton24:backport-pr-3741
Aug 5, 2026
Merged

[Port dspace-9_x] browse pages should not ignore sort config from back end#6069
tdonohue merged 1 commit into
DSpace:dspace-9_xfrom
jsutton24:backport-pr-3741

Conversation

@jsutton24

Copy link
Copy Markdown

References

Description

Backports the changes made in #3741 to the dspace-9_x branch.

Instructions for Reviewers

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR follows all coding best practices based on the Code Conventions Guide
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

…nore-sort-config-fix-UI-main

browse pages should not ignore sort config from back end
@lgeggleston lgeggleston added bug component: Discovery related to discovery search or browse system 1 APPROVAL pull request only requires a single approval to merge labels Aug 5, 2026
@lgeggleston lgeggleston moved this to 👍 Reviewer Approved in DSpace Maintenance (10.x, 9.x, 8.x) Aug 5, 2026
@lgeggleston lgeggleston added this to the 9.4 milestone Aug 5, 2026
@tdonohue tdonohue added the port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release label Aug 5, 2026
@tdonohue tdonohue changed the title [dspace-9_x] Backport #3741 (browse pages should not ignore sort config) [Port dspace-9_x] browse pages should not ignore sort config from back end Aug 5, 2026

@tdonohue tdonohue left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @jsutton24 ! I've reviewed this PR and verified it's an accurate backport of #3741.

I'm going to also attempt to auto-backport this to the dspace-8_x branch, as this PR may backport cleanly.

@tdonohue
tdonohue merged commit e64847c into DSpace:dspace-9_x Aug 5, 2026
16 checks passed
@github-project-automation github-project-automation Bot moved this from 👍 Reviewer Approved to ✅ Done in DSpace Maintenance (10.x, 9.x, 8.x) Aug 5, 2026
@dspace-bot

Copy link
Copy Markdown
Contributor

Backport failed for dspace-8_x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin dspace-8_x
git worktree add -d .worktree/backport-6069-to-dspace-8_x origin/dspace-8_x
cd .worktree/backport-6069-to-dspace-8_x
git switch --create backport-6069-to-dspace-8_x
git cherry-pick -x 2dc67bdf06b49e6093f5831bba4268a5a37df320

@tdonohue

tdonohue commented Aug 5, 2026

Copy link
Copy Markdown
Member

Oh well, this was unable to be autobackported to 8.x. But, will be fixed in 9.x as of the 9.4 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge bug component: Discovery related to discovery search or browse system port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release

Projects

Development

Successfully merging this pull request may close these issues.

4 participants