Make possible for the game cmake to tell which variable to pass to the NaCl subinvocation#1991
Open
illwieckz wants to merge 2 commits into
Open
Make possible for the game cmake to tell which variable to pass to the NaCl subinvocation#1991illwieckz wants to merge 2 commits into
illwieckz wants to merge 2 commits into
Conversation
…s to the NaCl subinvocation It's used by Unvanquished to pass CBSE_PYTHON_PATH. Also delete DAEMON_CBSE_PYTHON_PATH (already moved to the game as CBSE_PYTHON_PATH).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make possible for the game cmake to tell which variable to pass to the NaCl subinvocation
It's used by Unvanquished to pass
CBSE_PYTHON_PATH.Also delete
DAEMON_CBSE_PYTHON_PATH(already moved to the game asCBSE_PYTHON_PATH).Also remove
DaemonCBSE.cmake(already moved to the game).I noticed it while implementing nexe building in
macos-amd64CI, the custom python wouldn't be used in the subinvocation and the build would fail.See the game counterpart: