Skip to content

Disable DEP qualifications outside of MSVC, no prereserved sandbox size on macOS#38

Open
illwieckz wants to merge 2 commits into
masterfrom
illwieckz/msvc
Open

Disable DEP qualifications outside of MSVC, no prereserved sandbox size on macOS#38
illwieckz wants to merge 2 commits into
masterfrom
illwieckz/msvc

Conversation

@illwieckz

@illwieckz illwieckz commented Jul 7, 2026

Copy link
Copy Markdown
Member
  • win32: disable DEP qualifications outside of MSVC

Fixup for:

This broke MinGW Windows build:

src/trusted/platform_qualify/win/nacl_dep_qualify.c:24:3: error:
 '__try' undeclared (first use in this function)
   24 |   __try {
      |   ^~~~~
src/trusted/platform_qualify/win/nacl_dep_qualify.c:24:8:
 error: expected ';' before '{' token
   24 |   __try {
      |        ^~
      |        ;
  • posix: g_prereserved_sandbox_size only exists on Linux, not on macOS

Fixup for:

This broke AppleClang macOS build:

src/trusted/service_runtime/posix/addrspace_teardown.c:21:7:
 error: use of undeclared identifier 'g_prereserved_sandbox_size'
   21 |   if (g_prereserved_sandbox_size > 0) {
      |       ^
1 error generated.

@illwieckz illwieckz changed the title Disable DEP qualifications outside of MSVC Disable DEP qualifications outside of MSVC, no prereserved sandbox size on macOS Jul 7, 2026
@illwieckz illwieckz mentioned this pull request Jul 7, 2026
@illwieckz illwieckz requested a review from slipher July 7, 2026 10:48
@illwieckz illwieckz mentioned this pull request Jul 7, 2026
@slipher

slipher commented Jul 9, 2026

Copy link
Copy Markdown
Member

LGTM to posix: g_prereserved_sandbox_size only exists on Linux, not on macOS. Commit message nit: it actually does exist on Mac but can't be set to a nonzero value... the header declaration has a Linux ifdef on it, but the definition doesn't.

@illwieckz

Copy link
Copy Markdown
Member Author

I can rename posix: g_prereserved_sandbox_size only exists on Linux, not on macOS as posix: g_prereserved_sandbox_size is unused on macOS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants