Get tests all working in Windows#41
Open
slipher wants to merge 6 commits into
Open
Conversation
https://github.com/AntonLydike/filecheck 7687ec52167597c7a0c7ad3634bf4aff4deb41aa git add filecheck/*.py README.md LICENSE.txt
But mark them as broken regardless of OS, with the idea of disabling them in a possible CI.
The tests in mmap_unittest.cc are fast on Linux but take several minutes to complete on Windows. Build it as a separate target from the other unit tests and mark it as a huge test on Windows.
The real ntdll patching code works and passes its tests but this simplified version in the test somehow doesn't work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the 64-bit Windows Scons build I can now run
small_tests medium_tests large_testswith all passing.