Repository navigation
chore: upgrade @databiosphere/findable-ui to v61.0.0 (#5031) - #5032
Merged
Merged
Conversation
Raise `ky` to `^1.10.0` to match findable-ui v61's peer range. Keep `sort: "entryId"` in the AnVIL `defaultListParams` and note that it now only orders the build-time dataset fetch in `getStaticPaths`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: cc-claude-tools <cc-claude-tools@clevercanary.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the dependency update and accompanying configuration comment.
No open issues 🎉
What changed in this PR
Upgrades the data browser’s shared @databiosphere/findable-ui dependency to v61.0.0 for #5031 and aligns the declared ky range with its peer requirement.
Changes:
- Updates findable-ui to
^61.0.0, with the lockfile resolving61.0.0. - Raises the
kyrange to^1.10.0without changing its installed version. - Adds a comment explaining why AnVIL retains
sort: "entryId"for build-time dataset fetching; no configuration behavior changes.
| File | Description |
|---|---|
site-config/anvil-cmg/dev/config.ts |
Documents the retained build-time dataset sort. |
package.json |
Updates the findable-ui and ky dependency ranges. |
package-lock.json |
Locks findable-ui to v61.0.0 and synchronizes dependency metadata. |
Review effort: Balanced
frano-m
marked this pull request as ready for review
November 11, 2026 06:49
NoopDog
approved these changes
Nov 11, 2026
NoopDog
left a comment
Collaborator
There was a problem hiding this comment.
Thanks. I traced the getStaticPaths path through fetchAllEntities into v61's fetchEntitiesFromQuery, and the AnVIL sort does still reach the build-time dataset fetch, so the comment is accurate. None of v61's removed exports are imported here, and lint, type check, unit tests and the AnVIL build all pass locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5031
What changed
@databiosphere/findable-uigoes from^60.0.0to^61.0.0inpackage.json, andpackage-lock.jsonresolves61.0.0. This also brings in the60.0.1patch.kygoes from^1to^1.10.0inpackage.json, to match findable-ui v61's new peer range. The lockfile already resolvedky1.14.3, so no installed version changes.site-config/anvil-cmg/dev/config.tskeepssort: "entryId"indataSource.defaultListParams, with a comment saying that it now only orders the build-time dataset fetch ingetStaticPaths.Why
findable-ui v61.0.0 is the latest release (release notes). It is a breaking release, but none of its breaking changes need code changes here:
closeAndRestoreFocus, the filterCheckbox,isNodeBoolean,lib/components/utilsoruseEntityList.versionInfo: true, so the footer's version-chip change has no effect.ExploreViewinpages/[entityListType]/index.tsxstill receives statically loaded entities the way v61 expects.v61's explore list now sends only
sizefromdefaultListParams, so the AnVILsortlooks unused. It is not.getStaticPathsbuilds the AnVIL dataset detail pages with findable-ui'sfetchAllEntities, which still mergesdefaultListParamsinto every request. Removingsortwould change that paging from the uniqueentryIdto the API's default order. The comment records this so the key is not removed later.Assumptions I made
tableOptions.initialState.sorting. I confirmed in the browser that Datasets, Donors, BioSamples, Activities and Files each request their configured sort column.describe.skipine2e/anvil-catalog/anvilcatalog-sort.spec.ts, not from this change.How to verify
Definition of done from #5031:
@databiosphere/findable-uiis at^61.0.0inpackage.jsonand61.0.0inpackage-lock.json. (Step 1)kyis at^1.10.0inpackage.json. (Step 1)npx tsc --noEmit, lint, and the builds for every site config (HCA DCP, AnVIL, AnVIL catalog, LungMAP) pass. (Steps 2 and 3)npm test) and e2e tests (npx playwright test) pass. (Step 4)Steps:
package.jsonandpackage-lock.json. findable-ui should be^61.0.0and61.0.0, andkyshould be^1.10.0.npm ci, thennpx tsc --noEmitandnpm run lint. There should be no type errors and no lint errors.npm run build-ma-dev:hca-dcp,npm run build-cc-dev:anvil-cmg,npm run build-dev:anvil-catalogandnpm run build-dev:lungmap. Each build should succeed.npx jest --ci,npm run test:anvil-cmgandnpm run test:anvil-catalog. Nothing should be running on port 3000 first, because the e2e configs reuse any server already there. Locally, 282 unit tests, 132 AnVIL tests and 48 AnVIL catalog tests passed.npm run dev:anvil-cmgand open each tab. Each tab should open sorted by its configured default column (for example Files by file name), and the list request should not includesort=entryId. Page forward, change the sort, and apply a filter. The list and counts should update.npm run dev:hca-dcpandnpm run dev:lungmap.Screenshots
🤖 Generated with Claude Code
🐦 Built with cc-claude-tools