CORE=69: bump sonar plugin to gain JRE auto-provisioning - #141
Merged
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark
Details
| Benchmark suite | Current: eaa7710 | Previous: 20035c2 | Ratio |
|---|---|---|---|
bio.terra.pfb.LibraryBenchmarks.showNodesMedium |
1477.8645856104768 ops/s |
1486.1310243076252 ops/s |
0.99 |
bio.terra.pfb.LibraryBenchmarks.showNodesSmall |
24304.34331956949 ops/s |
21446.130770847907 ops/s |
1.13 |
bio.terra.pfb.PfbReaderBenchmarks.convertEnum |
7084710.503332313 ops/s |
5178382.502453218 ops/s |
1.37 |
This comment was automatically generated by workflow using github-action-benchmark.
|
|
aednichols
approved these changes
Sep 2, 2026
jgainerdewar
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the Sonar gradle plugin from
4.4.1.3373to7.4.0.8496, and moves the SourceClear plugin to theplugins {}block.Sonar scans are failing (example) with an error:
The Sonar plugin, as of 6.0, downloads its own dedicated JRE. We were on an older plugin version that didn't know how to do this. So: upgrade the plugin.
However, upgrading the Sonar plugin ran into class-conflict errors with a SourceClear transitive dependency. The SourceClear plugin didn't need to be declared in
buildSrc, so move it toplugins {...}so gradle can better manage its classpath.