Skip to content

Populate source.name and source.version on flag_evaluations and exposures EVP #12200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
vjfridge wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Populate source.name and source.version on flag_evaluations and exposures EVP #12200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
02f2a4d
Populate source.name and source.version on flag_evaluations and expos…
vjfridge Aug 12, 2026
8ed8522
Tighten comments: drop ticket refs and redundant javadoc
vjfridge Aug 12, 2026
5dc3b91
Merge branch 'master' into vickie/ffl-2995-sdk-name-and-version-java
vjfridge Aug 13, 2026
4aa5a6f
fix(openfeature): emit source.name/version per-event, not in batch co…
vjfridge Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...ing/feature-flagging-lib/src/main/java/com/datadog/featureflag/FeatureFlagEvpContext.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,10 @@ static Map<String, String> from(final Config config) {
if (config.getVersion() != null) {
context.put("version", config.getVersion());
}
// SDK identity (source.name / source.version) is emitted per-event at the top level
// (sibling of flag/variant/targeting_key), matching the flagevaluation track schema in
// logs-backend. Putting it in the batch context would map it to context.source.*, which is
// not a declared facet and causes the indexer to drop the event.
return context;
}
}
16 changes: 16 additions & 0 deletions ...ng/feature-flagging-lib/src/main/java/com/datadog/featureflag/FlagEvaluationPayloads.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package com.datadog.featureflag;

import datadog.communication.ddagent.TracerVersion;
import com.squareup.moshi.JsonAdapter;
import com.squareup.moshi.Moshi;
import com.squareup.moshi.Types;
Expand Down Expand Up @@ -157,6 +158,9 @@ private byte[] toByteArray() {
}
}

private static final String SOURCE_NAME = "dd-trace-java";
private static final String SOURCE_VERSION = TracerVersion.TRACER_VERSION;

static class FlagEvaluationEvent {
public final long timestamp;
public final FlagKeyObject flag;
Expand All @@ -168,6 +172,7 @@ static class FlagEvaluationEvent {
public final String targeting_key;
public final Boolean runtime_default_used;
public final EventContext context;
public final SourceObject source;
public final ErrorObject error;

FlagEvaluationEvent(
Expand Down Expand Up @@ -196,6 +201,7 @@ static class FlagEvaluationEvent {
(evaluationAttrs != null && !evaluationAttrs.isEmpty())
? new EventContext(evaluationAttrs)
: null;
this.source = new SourceObject(SOURCE_NAME, SOURCE_VERSION);
this.error =
(errorMessage != null && !errorMessage.isEmpty()) ? new ErrorObject(errorMessage) : null;
}
Expand Down Expand Up @@ -284,6 +290,16 @@ static class ErrorObject {
}
}

static class SourceObject {
public final String name;
public final String version;

SourceObject(final String name, final String version) {
this.name = name;
this.version = version;
}
}

static class EventContext {
public final Map<String, Object> evaluation;

Expand Down
4 changes: 4 additions & 0 deletions ...gging/feature-flagging-lib/src/test/java/com/datadog/featureflag/ExposureWriterTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
import com.squareup.moshi.Moshi;
import datadog.communication.ddagent.DDAgentFeaturesDiscovery;
import datadog.communication.ddagent.SharedCommunicationObjects;
import datadog.communication.ddagent.TracerVersion;
import datadog.trace.agent.test.server.http.JavaTestHttpServer;
import datadog.trace.agent.test.server.http.JavaTestHttpServer.HandlerApi;
import datadog.trace.api.Config;
Expand Down Expand Up @@ -287,6 +288,9 @@ private static void assertContext(
assertEquals(service == null ? "unknown" : service, context.get("service"));
assertOptionalContextValue(context, "env", env);
assertOptionalContextValue(context, "version", version);
// SDK identity populated by FeatureFlagEvpContext.
assertEquals("dd-trace-java", context.get("source.name"));
assertEquals(TracerVersion.TRACER_VERSION, context.get("source.version"));
}

private static void assertOptionalContextValue(
Expand Down