perf(feature-flagging): bound exposure delivery memory - #12213
Draft
leoromanovsky wants to merge 2 commits into
Draft
perf(feature-flagging): bound exposure delivery memory#12213leoromanovsky wants to merge 2 commits into
leoromanovsky wants to merge 2 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
Contributor
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Persistent delivery failures retain the complete exposure buffer. New unique events increase that buffer after every failed flush.
A local synthetic test sent 40 batches of 25 unique events to an endpoint that returned HTTP 400. The writer retained 1,000 events. The next request was 390,085 bytes. The retained event count and request size increased linearly. This increases heap use, serialization work, and network traffic during an outage.
The change enforces one delivery attempt per event. It limits a handler batch to 1,000 events and each request body to 5 MiB.
Changes and Decisions
Validation
The same local synthetic test made 40 delivery attempts. It retained no failed events for replay. The largest request contained 38 events and 14,905 bytes. Attempts stopped after the final batch.