Bound feature flag evaluation aggregation memory - #12215
Draft
leoromanovsky wants to merge 1 commit into
Draft
Conversation
Contributor
|
🎯 Code Coverage (details) 🔗 Commit SHA: 21b8641 | Docs | Datadog PR Page | Give us feedback! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The current count limits do not bound retained heap when full evaluation data is enabled. JOL measured a typical 256-field bucket at 60,021 bytes. It measured a maximum legal bucket at 297,589 bytes. At the global count limit, these profiles project to 7.3 GiB and 36.3 GiB. This memory can remain until the 10-second flush.
Changes and Decisions
Validation
JOL measured the retained object graph after the first byte-budget degradation: