Repository navigation
Reject feature flags with invalid allocation exposure settings - #12968
Draft
leoromanovsky wants to merge 1 commit into
Draft
leoromanovsky wants to merge 1 commit into
leoromanovsky wants to merge 1 commit into
Conversation
Contributor
Contributor
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Reject a flag when any allocation omits
doLog, suppliesnull, or supplies a non-boolean value. Evaluation returns the application default withERROR/PARSE_ERROR. Valid neighboring flags remain available. Explicittrueandfalseremain valid.Motivation
The UFC schema requires a boolean
doLog. Accepting malformed values silently changes exposure behavior and creates differences between SDKs.Additional Notes
Depends on ffe-system-test-data#51, pinned at
f6c8ad870531d041eaef42286899c93ad4d6e0e9. Shared cases cover invalid values before a fallback and after an earlier matching allocation. Parser tests verify flag isolation and both valid boolean values.Local system tests are pending. Unit tests and formatting pass.
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issue. Usesolvesinstead, and assign the PR milestone to the issue./merge. You can also customize the commit message with/merge --commit-message "...", remove it with/merge -c, or skip checks with/merge -f --reason "reason". See merge queue documentation.Jira ticket: not assigned.