Skip to content

Reject feature flags with invalid allocation exposure settings - #12968

Draft
leoromanovsky wants to merge 1 commit into
masterfrom
leoromanovsky/dolog-required
Draft

leoromanovsky wants to merge 1 commit into
masterfrom
leoromanovsky/dolog-required

Conversation

@leoromanovsky

Copy link
Copy Markdown
Contributor

What Does This Do

Reject a flag when any allocation omits doLog, supplies null, or supplies a non-boolean value. Evaluation returns the application default with ERROR / PARSE_ERROR. Valid neighboring flags remain available. Explicit true and false remain valid.

Motivation

The UFC schema requires a boolean doLog. Accepting malformed values silently changes exposure behavior and creates differences between SDKs.

Additional Notes

Depends on ffe-system-test-data#51, pinned at f6c8ad870531d041eaef42286899c93ad4d6e0e9. Shared cases cover invalid values before a fallback and after an earlier matching allocation. Parser tests verify flag isolation and both valid boolean values.

Local system tests are pending. Unit tests and formatting pass.

Contributor Checklist

  • Format the title according to the contribution guidelines
  • Assign the type: and (comp: or inst:) labels in addition to any other useful labels
  • Avoid using close, fix, or any linking keywords when referencing an issue. Use solves instead, and assign the PR milestone to the issue.
  • Update the CODEOWNERS file on source file addition, migration, or deletion.
  • Update public documentation with any new configuration flags or behaviors.
  • Add your completed PR to the merge queue by commenting /merge. You can also customize the commit message with /merge --commit-message "...", remove it with /merge -c, or skip checks with /merge -f --reason "reason". See merge queue documentation.

Jira ticket: not assigned.

@leoromanovsky leoromanovsky added type: bug fix Bug fix tag: ai generated Largely based on code generated by an AI or LLM comp: openfeature OpenFeature labels Oct 20, 2026
@datadog-datadog-prod-us1-2

datadog-datadog-prod-us1-2 Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 80.31% (+20.47%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 7fca907 | Docs | Give us feedback!

@dd-octo-sts

dd-octo-sts Bot commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.77 s 14.63 s [-0.1%; +1.9%] (no difference)
startup:insecure-bank:tracing:Agent 13.54 s 13.63 s [-1.4%; +0.1%] (no difference)
startup:petclinic:appsec:Agent 17.12 s 16.49 s [-0.6%; +8.3%] (no difference)
startup:petclinic:iast:Agent 16.88 s 16.99 s [-1.7%; +0.4%] (no difference)
startup:petclinic:profiling:Agent 16.51 s 16.62 s [-1.5%; +0.2%] (no difference)
startup:petclinic:sca:Agent 17.03 s 16.78 s [+0.7%; +2.3%] (maybe worse)
startup:petclinic:tracing:Agent 16.10 s 15.78 s [-2.2%; +6.3%] (no difference)

Commit: 7fca9073 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: openfeature OpenFeature tag: ai generated Largely based on code generated by an AI or LLM type: bug fix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant