Repository navigation
Conversation
This comment has been minimized.
This comment has been minimized.
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
0bf5a0a to
71cc64b
Compare
Debugger benchmarksParameters
See matching parameters
SummaryFound 5 performance improvements and 0 performance regressions! Performance is the same for 5 metrics, 5 unstable metrics.
See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (350.255 µs) : 312, 389
. : milestone, 350,
basic (328.846 µs) : 324, 334
. : milestone, 329,
loop (8.089 ms) : 8026, 8152
. : milestone, 8089,
section candidate
noprobe (356.61 µs) : 307, 407
. : milestone, 357,
basic (321.499 µs) : 316, 327
. : milestone, 321,
loop (7.568 ms) : 7562, 7575
. : milestone, 7568,
|
71cc64b to
9923dbb
Compare
New context scopes now use the default async propagation setting, matching activateSpan. Re-attaching the current context preserves its existing setting. Preserve inheritance in the OpenTelemetry shim because makeCurrent() is a manual tracing API. A manual attachment inside a scope with async propagation disabled must keep it disabled, including if the application fails to close the manual scope. This keeps manual scope management from inadvertently re-enabling async propagation disabled by instrumentation.
9923dbb to
801bf5c
Compare
Codex Review Summary: 🔄 RunningThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
What Does This Do
New context attachments in the legacy scope manager use the default async propagation setting, matching
activateSpan. Re-attaching the current context preserves its existing setting. OpenTelemetry manual attachments continue to inherit disabled propagation from the active scope.Motivation
Agent-managed instrumentation should start new work with the default propagation setting. Manual tracing APIs should preserve a surrounding scope's disabled propagation so that manual scope management cannot inadvertently re-enable it.
Additional Notes
Stacked on #13305, which makes the propagation query return the default when no scope is active. The OTel shim preserves manual inheritance without adding another attachment method to the context API.